Bug 250344 - devel/libvirt: use flavored py-docutils in right way
Summary: devel/libvirt: use flavored py-docutils in right way
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-14 14:51 UTC by Dima Panov
Modified: 2020-10-14 16:57 UTC (History)
0 users

See Also:
novel: maintainer-feedback+

Attachments
devel/libvirt: use flavored py-docutils in right way (798 bytes, patch)
2020-10-14 14:51 UTC, Dima Panov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer freebsd_triage 2020-10-14 14:51:15 UTC 
Created attachment 218742 [details]
devel/libvirt: use flavored py-docutils in right way
Comment 1 Roman Bogorodskiy freebsd_committer freebsd_triage 2020-10-14 15:15:06 UTC 
Thanks, that looks good to me. Just one style nitpick: what's the point of "+=" for BINARY_ALIAS if that could be set once using "\" to break lines?
Comment 2 Dima Panov freebsd_committer freebsd_triage 2020-10-14 16:10:27 UTC 
(In reply to Roman Bogorodskiy from comment #1)
"+=" is a bad habit from openbsd ports/macports :)
just simply to read without tracking a trailing slashes in every line
Comment 3 Roman Bogorodskiy freebsd_committer freebsd_triage 2020-10-14 16:23:26 UTC 
(In reply to Dima Panov from comment #2)

Feel free to commit it, either way is fine, though I'd prefer slashes.
Or I'll commit it myself tomorrow.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-10-14 16:55:07 UTC 
A commit references this bug:

Author: fluffy
Date: Wed Oct 14 16:54:19 UTC 2020
New revision: 552344
URL: https://svnweb.freebsd.org/changeset/ports/552344

Log:
  devel/libvirt: use flavored py-docutils in right way

  PR:		250344
  Submitted by:	fluffy
  Approved by:	maintainer (novel)
  MFH:		2020Q4

Changes:
  head/devel/libvirt/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-10-14 16:57:09 UTC 
A commit references this bug:

Author: fluffy
Date: Wed Oct 14 16:56:08 UTC 2020
New revision: 552345
URL: https://svnweb.freebsd.org/changeset/ports/552345

Log:
  MFH: r552344

  devel/libvirt: use flavored py-docutils in right way

  PR:		250344
  Submitted by:	fluffy
  Approved by:	maintainer (novel)

  Approved by:	ports-secteam (fluffy)

Changes:
_U  branches/2020Q4/
  branches/2020Q4/devel/libvirt/Makefile
Comment 6 Dima Panov freebsd_committer freebsd_triage 2020-10-14 16:57:48 UTC 
Committed