Bug 250787 - net-mgmt/phpfpm_exporter: upstream bug was fixed without a release
Summary: net-mgmt/phpfpm_exporter: upstream bug was fixed without a release
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-01 20:30 UTC by Kamigishi Rei
Modified: 2023-02-17 22:40 UTC (History)
4 users (show)

See Also:
gasol.wu: maintainer-feedback+

Attachments
Drop-in patch for the port's files directory (365 bytes, patch)
2020-11-01 20:30 UTC, Kamigishi Rei 		no flags Details | Diff
Update to 0.6.1 (1.01 KB, patch)
2022-05-19 20:13 UTC, Kamigishi Rei 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kamigishi Rei 2020-11-01 20:30:02 UTC 
Created attachment 219282 [details]
Drop-in patch for the port's files directory

There is a bug with command line parsing in the 0.4.1 release source code. This was fixed in upstream: https://github.com/bakins/php-fpm-exporter/issues/20

See attached patch.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2020-11-03 04:22:59 UTC 
Do we also need the patch from https://github.com/bakins/php-fpm-exporter/pull/21 ?
Comment 2 Kamigishi Rei 2020-11-03 08:08:17 UTC 
Sadly I cannot test the fastcgi use case.

Is there a reason that we do not just update to 0.6.1?
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2020-11-07 16:37:42 UTC 
(In reply to Kamigishi Rei from comment #2)
You can submit a patch if you want
Comment 4 Kamigishi Rei 2022-05-19 20:13:43 UTC 
Created attachment 234040 [details]
Update to 0.6.1

Seems to build and work fine.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-02-17 22:37:16 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=43b8b3ff3b2a7c2fe9e16dc29fd806f10fff30da

commit 43b8b3ff3b2a7c2fe9e16dc29fd806f10fff30da
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-02-17 22:30:52 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-02-17 22:36:49 +0000

    net-mgmt/phpfpm_exporter: Update to 0.6.1

    Adapt submitted version (approved by maintainer) to follow Porters
    Handbook more closely and switch to go:modules while at it.

    Changelog:
    https://github.com/bakins/php-fpm-exporter/compare/v0.4.1...v0.6.1

    PR:             250787
    Reported by:    Kamigishi Rei <spambox@haruhiism.net>
    Reviewed by:    Gasol Wu <gasol.wu@gmail.com> (maintainer)

 net-mgmt/phpfpm_exporter/Makefile | 18 +++++++-----------
 net-mgmt/phpfpm_exporter/distinfo |  8 +++++---
 2 files changed, 12 insertions(+), 14 deletions(-)
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-02-17 22:40:52 UTC 
Committed with some modifications, sorry for the wait.