Bug 250877 - math/nauty: requesting maintainership
Summary: math/nauty: requesting maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-05 13:03 UTC by Moritz Schmitt
Modified: 2020-11-26 11:20 UTC (History)
1 user (show)

See Also:


Attachments
Update of math/nauty (5.82 KB, patch)
2020-11-25 20:41 UTC, Moritz Schmitt
no flags Details | Diff
Poudriere test log (38.65 KB, text/plain)
2020-11-25 20:45 UTC, Moritz Schmitt
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Moritz Schmitt 2020-11-05 13:03:56 UTC
math/nauty currently doesn't have a maintainer. I'd like to take over maintainership for this port.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2020-11-10 07:40:27 UTC
Hi Moritz,

Thanks for stepping up. Could you please attach a patch for this?
Comment 2 Moritz Schmitt 2020-11-25 20:41:12 UTC
Created attachment 219978 [details]
Update of math/nauty
Comment 3 Moritz Schmitt 2020-11-25 20:44:26 UTC
I finally found the time to prepare a patch for math/nauty. Here is what has changed:

- Change the order of MASTER_SITES as the uniroma1 one is the main one.

- Since DISTVERSION is not correctly translated by make anyway, we set
  PORTVERSION directly.

- Simplify DISTNAME.

- Update MAINTAINER.

- Remove post-extract target as all archives are compiled anyway.

- We created a pkg-plist file because PHB 3.2 states: "Usage of
  PLIST_FILES should not be abused. When looking for the origin of a
  file, people usually try to grep through the pkg-plist files in the
  ports tree. Listing files in PLIST_FILES in the Makefile makes that
  search more difficult."

- Make the install target simple and straightforward.

- Reorder sections of Makefile according to PHB Chap. 15.
Comment 4 Moritz Schmitt 2020-11-25 20:45:26 UTC
Created attachment 219979 [details]
Poudriere test log
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-11-26 11:19:13 UTC
A commit references this bug:

Author: fernape
Date: Thu Nov 26 11:18:21 UTC 2020
New revision: 556329
URL: https://svnweb.freebsd.org/changeset/ports/556329

Log:
  math/nauty: setting new MAINTAINER

  moritz@schmi.tt steps up to maintain this port and does some cleaning.

  Already maintainer of devel/cscope and devel/gindent.

  PR:	250877
  Submitted by:	moritz@schmi.tt

Changes:
  head/math/nauty/Makefile
  head/math/nauty/pkg-plist
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2020-11-26 11:20:29 UTC
Committed,

Thanks for stepping up to maintain this port!