Bug 250902 - www/googler: drop or make conditional xclip dependency
Summary: www/googler: drop or make conditional xclip dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nicola Vitale
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2020-11-06 13:21 UTC by Jan Beich
Modified: 2021-03-11 08:49 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (nivit)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2020-11-06 13:21:04 UTC 
I'm on Wayland, so use wl-copy instead of xclip. googler supports more tools:

     if shutil.which('xsel') is not None:
         copier_params = ['xsel', '-b', '-i']
     elif shutil.which('xclip') is not None:
         copier_params = ['xclip', '-selection', 'clipboard']
     elif shutil.which('wl-copy') is not None:
         copier_params = ['wl-copy']
     elif shutil.which('termux-clipboard-set') is not None:
         copier_params = ['termux-clipboard-set']
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-03-11 08:33:31 UTC 
A commit references this bug:

Author: nivit
Date: Thu Mar 11 08:32:39 UTC 2021
New revision: 568070
URL: https://svnweb.freebsd.org/changeset/ports/568070

Log:
  www/googler: update to 4.3.2

  Remove runtime dependency by xclip.  [1]
  Add pkg-message to inform the user that copy URL to clipboard requires
  an external program.

  PR:	250902  [1]
  Submitted by:	jbeich

Changes:
  head/www/googler/Makefile
  head/www/googler/distinfo
  head/www/googler/pkg-message
Comment 2 Nicola Vitale freebsd_committer freebsd_triage 2021-03-11 08:49:13 UTC 
Fixed. Thank you for the PR.