Bug 251318 - multimedia/mpv: removed support of libsmbclient - remove option SMB
Summary: multimedia/mpv: removed support of libsmbclient - remove option SMB
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-multimedia (Nobody)
URL: https://github.com/mpv-player/mpv/blo...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-22 23:04 UTC by Vladimir Druzenko
Modified: 2020-11-23 04:12 UTC (History)
1 user (show)

See Also:

Attachments
remove option SMB (677 bytes, patch)
2020-11-22 23:04 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2020-11-22 23:04:39 UTC 
Created attachment 219895 [details]
remove option SMB

> - stream_smb: remove due to lack of thread safety and the abundance
>  of alternatives, FFmpeg still includes SMB support

Build with SMB option ON fails.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-11-23 04:12:24 UTC 
A commit references this bug:

Author: jbeich
Date: Mon Nov 23 04:11:59 UTC 2020
New revision: 556085
URL: https://svnweb.freebsd.org/changeset/ports/556085

Log:
  multimedia/mpv: drop SMB option after r556071

  waf-light: error: no such option: --enable-libsmbclient
  https://github.com/mpv-player/mpv/commit/3b8b7cb9d481

  PR:		251318
  Submitted by:	VVD <vvd@unislabs.com>

Changes:
  head/multimedia/mpv/Makefile