Created attachment 220182 [details] Patch for math/libnormaliz - Update port to version 3.8.9 - Update MAINTAINER - Shorten pkg-descr and make it less technical - Sort pkg-plist alphabetically - Rewrite COMMENT - Reorder variables in Makefile according to Chap. 15 of the PHB
Created attachment 220183 [details] Poudriere test log
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/224437659
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. Thanks!
Hi Moritz, Great work with the port. Can we do the last adjustments? # PORTNAME block PORTNAME DISTVERSION CATEGORIES MASTER_SITES DISTNAME # Maintainer block MAINTAINER COMMENT # License block LICENSE LICENSE_FILE # Dependencies BUILD_DEPENDS # USES block USES # Configure block +GNU_CONFIGURE # Make block MAKEFILE -GNU_CONFIGURE # CFLAGS/CXXFLAGS/LDFLAGS block +CXXFLAGS +LDFLAGS # WRKSRC block BUILD_WRKSRC INSTALL_WRKSRC # Options definitions OPTIONS_DEFINE # Options descriptions COCOA_DESC +FLINT_DESC # Options helpers COCOA_BUILD_DEPENDS COCOA_CONFIGURE_WITH -FLINT_DESC FLINT_LIB_DEPENDS FLINT_CONFIGURE_WITH FLINT_LDFLAGS OPENMP_CONFIGURE_ENABLE -CXXFLAGS -LDFLAGS Thanks!
Hi Fernando, Thanks for your helpful suggestions! I'm happy to include all of them in my patch because I don't feel strongly about it anyway. However, out of curiosity, I have a few rather specific questions if I may: - Why do you think we should change the order of MAKEFILE and GNU_CONFIGURE? Both are bsd.ports.mk variables, and I sorted these variables alphabetically. - Since BUILD_WRKSRC and INSTALL_WRKSRC are bsd.ports.mk variables as well, shouldn't we put all variables in one big bsd.ports.mk block? This would match well with Chap. 15 of PHB. - Since LDFLAGS and CXXFLAGS are not part of any previous blocks, I put them at the very end as suggested by PHB 15.11. Why do you think they should be moved up? None of this is essential, of course, but I think having some kind of standard when it comes to ports would be of great value. This is why I'm asking.
(In reply to Moritz Schmitt from comment #5) Hi Moritz After the patch, I see this: ... MAKEFILE= Makefile.classic GNU_CONFIGURE= yes ... So alphabetically, GNU_CONFIGURE should be first. It should go first also logically. For BUILD_WRKSRC and INSTALL_WRKSRC and think it is good as you have them now. I usually like to have a blank line to separate this kind of "subsections", like *_WRKSRC stuff and others, but this is just a matter of taste :-) LDFLAGS and CFLAGS are defined in bsd.port.mk so they should go after USES (more or less). The same applies for CONFIGURE_* and *_CONFIGURE according to PHB 15.9. But as you said, nothing of this is essential and some of these warnings are a matter of preference. For example I rather have something like USE=cmake perl5 CMAKE_* =.... USE_PERL5=... than USE=cmake perl5 USE_PERL5=... CMAKE_* =.... Even if that triggers some warnings. If you want to change something let me know and I will wait before committing this. Cheers!
Created attachment 220230 [details] Patch for math/libnormaliz
(In reply to Fernando Apesteguía from comment #6) Thanks for your explanations, Fernando! I integrated all your suggestions into my patch. Please let me know if you find other issues.
A commit references this bug: Author: fernape Date: Fri Dec 4 07:22:12 UTC 2020 New revision: 556955 URL: https://svnweb.freebsd.org/changeset/ports/556955 Log: math/libnormaliz: Update port and set MAINTAINER ChangeLog: https://github.com/Normaliz/Normaliz/releases/tag/v3.8.9 Pet linters Submitter becomes maintainer PR: 251542 Submitted by: moritz@schmi.tt Changes: head/math/libnormaliz/Makefile head/math/libnormaliz/distinfo head/math/libnormaliz/pkg-descr head/math/libnormaliz/pkg-plist