Bug 251554 - multimedia/gtk-youtube-viewer: Update to 3.8.0 & Adopt Port
Summary: multimedia/gtk-youtube-viewer: Update to 3.8.0 & Adopt Port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/trizen/youtube-vie...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-12-03 04:47 UTC by Neel Chauhan
Modified: 2020-12-04 07:22 UTC (History)
2 users (show)

See Also:

Attachments
Patch (Revision 1) (2.14 KB, patch)
2020-12-03 04:47 UTC, Neel Chauhan 		no flags Details | Diff
Patch (Revision 2) (455 bytes, patch)
2020-12-03 18:14 UTC, Neel Chauhan 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2020-12-03 04:47:49 UTC 
Created attachment 220205 [details]
Patch (Revision 1)

Passes poudriere.
Comment 1 Automation User 2020-12-03 06:35:33 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/224582971
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-03 09:31:38 UTC 
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Q/A: Makefile: "USES" has to appear earlier.

^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html


Thanks!
Comment 3 Neel Chauhan freebsd_committer freebsd_triage 2020-12-03 15:59:22 UTC 
From my portlint, I don't see the "USES has to appear earlier" error. I get:

root@omen:/usr/ports/multimedia/gtk-youtube-viewer # portlint
WARN: Makefile: [29]: possible direct use of command "patch" found. use ${PATCH} instead.
0 fatal errors and 1 warning found.
root@omen:/usr/ports/multimedia/gtk-youtube-viewer #

And that's because of this line:

root@omen:/usr/ports/multimedia/gtk-youtube-viewer # grep USE_PERL Makefile
USE_PERL5=      patch modbuild
root@omen:/usr/ports/multimedia/gtk-youtube-viewer #
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-03 18:10:44 UTC 
(In reply to Neel Chauhan from comment #3)

The message might be misleading. The culprit is that NO_ARCH should be after USES, and hence the message "USES has to appear earlier"
Comment 5 Neel Chauhan freebsd_committer freebsd_triage 2020-12-03 18:14:53 UTC 
Created attachment 220226 [details]
Patch (Revision 2)

Moved NO_ARCH
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-03 18:22:51 UTC 
(In reply to Neel Chauhan from comment #5)

Thanks for that :-)

It will take some time to build and test, there are heavy ports in the dependency chain :S
Comment 7 commit-hook freebsd_committer freebsd_triage 2020-12-04 07:16:47 UTC 
A commit references this bug:

Author: fernape
Date: Fri Dec  4 07:16:10 UTC 2020
New revision: 556951
URL: https://svnweb.freebsd.org/changeset/ports/556951

Log:
  multimedia/gtk-youtube-viewer: Update to 3.8.0 and set MAINTAINER

  ChangeLog: https://github.com/trizen/youtube-viewer/releases/tag/3.8.0

  Submitter becomes maintainer.

  PR:	251554
  Submitted by:	neel@neelc.org

Changes:
  head/multimedia/gtk-youtube-viewer/Makefile
  head/multimedia/gtk-youtube-viewer/distinfo
  head/multimedia/gtk-youtube-viewer/pkg-plist
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-04 07:22:42 UTC 
Committed,

Thanks!