Bug 251644 - x11-toolkits/wxgtk31: remove unused gconf2 dependency
Summary: x11-toolkits/wxgtk31: remove unused gconf2 dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Loïc Bartoletti
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-12-06 15:47 UTC by Val Packett
Modified: 2020-12-08 06:22 UTC (History)
3 users (show)

See Also:
lbartoletti: maintainer-feedback+


Attachments
wxgtk-conf.patch (4.90 KB, patch)
2020-12-06 15:47 UTC, Val Packett
val: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2020-12-06 15:47:41 UTC
Created attachment 220317 [details]
wxgtk-conf.patch

The wxgtk source does not mention gconf anywhere, so the  `GSTREAMER_USE= GNOME=gconf2` line should be removed, as it introduces an unwanted gtk2 dependency.

I've tested wxgtk31 in poudriere, but I assume the same applies to at least wxgtk30, so the patch here touches both.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-12-06 19:55:25 UTC
A commit references this bug:

Author: yuri
Date: Sun Dec  6 19:54:59 UTC 2020
New revision: 557168
URL: https://svnweb.freebsd.org/changeset/ports/557168

Log:
  x11-toolkits/wxgtk31: Remove unused gconf2 dependency

  PR:		251644
  Submitted by:	greg@unrelenting.technology

Changes:
  head/x11-toolkits/wxgtk31/Makefile
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2020-12-06 19:56:13 UTC
x11-toolkits/wxgtk30 is maintained by lbartoletti@, assigning to him.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-12-08 05:58:59 UTC
A commit references this bug:

Author: lbartoletti
Date: Tue Dec  8 05:58:56 UTC 2020
New revision: 557261
URL: https://svnweb.freebsd.org/changeset/ports/557261

Log:
  x11-toolkits/wxgtk30: Remove unused gconf2 dependency

  PR:		251644
  Submitted by:	greg@unrelenting.technology

Changes:
  head/x11-toolkits/wxgtk30/Makefile
Comment 4 Loïc Bartoletti freebsd_committer freebsd_triage 2020-12-08 06:22:36 UTC
Committed, thanks!