Bug 251671 - games/devilutionX: correct DEBUG option / remove unnecessary patch
Summary: games/devilutionX: correct DEBUG option / remove unnecessary patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-07 18:54 UTC by Nuno Teixeira
Modified: 2020-12-15 12:46 UTC (History)
1 user (show)

See Also:

Attachments
Sugested svn patch (1.38 KB, patch)
2020-12-07 18:54 UTC, Nuno Teixeira 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2020-12-07 18:54:08 UTC 
Created attachment 220353 [details]
Sugested svn patch

Hello,

- remove unnecessary patch thats adds "#include <strings.h>" to 3rdParty/StormLib/src/StormPort.h because already included upstream.

- replace NIGHTLY_BUILD (optimizations/debug) with DEBUG as discussed in https://github.com/diasurgical/devilutionX/issues/908 and described in project docs:

Debug builds
-DDEBUG=OFF disable debug mode of the Diablo engine.

Thanks,

Nuno Teixeira
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-12-15 12:45:13 UTC 
A commit references this bug:

Author: makc
Date: Tue Dec 15 12:44:32 UTC 2020
New revision: 558159
URL: https://svnweb.freebsd.org/changeset/ports/558159

Log:
  games/devilutionX:
  - Remove patch which is already included upstream
  - Use debug mode instead of nightly_build for WITH_DEBUG

  PR:		251671
  Submitted by:	Nuno Teixeira (maintainer)

Changes:
  head/games/devilutionX/Makefile
  head/games/devilutionX/files/patch-3rdParty_StormLib_src_StormPort.h
Comment 2 Max Brazhnikov freebsd_committer freebsd_triage 2020-12-15 12:46:05 UTC 
Thanks!