Bug 251672 - textproc/cast2gif: ONLY_FOR_ARCHS=amd64
Summary: textproc/cast2gif: ONLY_FOR_ARCHS=amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-07 19:25 UTC by Nuno Teixeira
Modified: 2020-12-13 08:21 UTC (History)
1 user (show)

See Also:


Attachments
Sugested svn patch (378 bytes, patch)
2020-12-07 19:25 UTC, Nuno Teixeira
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2020-12-07 19:25:12 UTC
Created attachment 220355 [details]
Sugested svn patch

Hello,

cargo-crates/font-kit lists only the following
platforms:

  x86_64-unknow-linux-gnu
  x86_64-pc-windows-msvc
  i686-pc-windows-msvc
  x86_64-apple-darwin

and it fails to compile on i386:

...
error[E0308]: mismatched types
   --> /wrkdirs/usr/ports/textproc/cast2gif/work/cast2gif-4f76eeb/cargo-crates/font-kit-0.6.0/src/loaders/freetype.rs:811:21
    |
811 |                 yy: matrix.w() as i64,
    |                     ^^^^^^^^^^^^^^^^^ expected `i32`, found `i64`
...

full log: http://beefy10.nyi.freebsd.org/data/114i386-default/557100/logs/cast2gif-0.1.0.p1.log

Thanks,

Nuno Teixeira
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2020-12-12 10:11:21 UTC
Hi Nuno,

I think with the patch from Github [1] it now builds not only on amd64 and armv7, but also on the others arches, including i386.

[1] https://github.com/servo/font-kit/commit/cc92c3fb65792fa716728407f5651343e1bbe155


Could you please try the new patch from my review [2] for builds other than amd64 and report back? Thanks!

[2] https://reviews.freebsd.org/D27516
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2020-12-13 06:49:07 UTC
(In reply to Rainer Hurling from comment #1)

Hi,

Thats good news but I can't test it on other archs because my actual laptop doesn't handle it.

Could you please submit that patch?

I will follow freebsd poudriere builds to see other archs builds.

Thanks
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-12-13 08:20:43 UTC
A commit references this bug:

Author: rhurlin
Date: Sun Dec 13 08:20:13 UTC 2020
New revision: 557887
URL: https://svnweb.freebsd.org/changeset/ports/557887

Log:
  textproc/cast2gif: Fix for 32bit archs

  Patch for internal cargo-crates/font-kit [1] to make
  textproc/cast2gif also executable on 32bit platforms.

  [1] https://github.com/servo/font-kit/commit/cc92c3fb65792fa716728407f5651343e1bbe155

  PR:		251672
  Submitted by:	Nuno Teixeira <ed.arrakis@gmail.com> (maintainer)
  Approved by:	arrowd (mentor)
  Differential Revision:	https://reviews.freebsd.org/D27516

Changes:
  head/textproc/cast2gif/files/patch-cargo-crates_font-kit-0.6.0_src_loaders_freetype.rs
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2020-12-13 08:21:31 UTC
Committed, thanks :)