Description Dimitry Andric 2020-12-08 18:16:05 UTC

Created attachment 220370 [details]
Fix lua version check in mail/opendkim

Attempting to build mail/opendkim 2.10.3_11 with lua 5.4 installed (i.e. with DEFAULT_VERSIONS+=lua=5.4 in make.conf) leads to warnings and errors:

...
Making all in miltertest
cc -DHAVE_CONFIG_H -I. -I..  -I./../libopendkim -I/usr/include -I/usr/local/include/lua54 -DCONFIG_BASE=\"/usr/local/etc\"  -O2 -pipe -march=haswell  -fstack-protector-strong -fno-strict-aliasing -MT miltertest-miltertest.o -MD -MP -MF .deps/miltertest-miltertest.Tpo -c -o miltertest-miltertest.o `test -f 'miltertest.c' || echo './'`miltertest.c
miltertest.c:4016:2: warning: implicit declaration of function 'luaL_register' is invalid in C99 [-Wimplicit-function-declaration]
        luaL_register(l, "mt", mt_library);
        ^
miltertest.c:4171:54: error: too few arguments to function call, expected 5, have 4
                         script == NULL ? "(stdin)" : script))
                                                            ^
/usr/local/include/lua54/lua.h:289:1: note: 'lua_load' declared here
LUA_API int   (lua_load) (lua_State *L, lua_Reader reader, void *dt,
^
/usr/local/include/lua54/luaconf.h:292:18: note: expanded from macro 'LUA_API'
#define LUA_API         extern
                        ^
1 warning and 1 error generated.
*** Error code 1

This is because ports r488837 changed the #if statements in this file, but didn't use >= to check for any version of lua >= 5.2.

Attached patch will make it all work for a while, until lua messes up their API again.