Bug 251795 - lang/mono: convert to metaport
Summary: lang/mono: convert to metaport
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
: 258956 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-12-13 03:21 UTC by Mark Linimon
Modified: 2023-08-14 01:37 UTC (History)
5 users (show)

See Also:


Attachments
patch to lang/mono/Makefile (3.37 KB, patch)
2020-12-13 03:21 UTC, Mark Linimon
no flags Details | Diff
patch to lang/mono/Makefile (3.20 KB, patch)
2020-12-17 04:23 UTC, Mark Linimon
no flags Details | Diff
patch to Mk/bsd.default-versions.mk (deleted)
2020-12-17 04:27 UTC, Mark Linimon
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2020-12-13 03:21:03 UTC
Created attachment 220518 [details]
patch to lang/mono/Makefile

This is a WIP to convert lang/mono to a metaport.  Only the Makefile and pkg-descr (itself unchanged) will remain under this directory if this proposal is approval.  In that case, the current lang/mono will be repocopied to lang/mono5.X
where X is to be determined.  (Currently under test).

lang/mono6.8 has already been committed.  However, we know that some of the ports that depend on it do not build.  That is also currently being investigated.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2020-12-17 04:23:27 UTC
Created attachment 220652 [details]
patch to lang/mono/Makefile

Now more succint, and passes testing.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2020-12-17 04:27:07 UTC
Created attachment 220653 [details]
patch to Mk/bsd.default-versions.mk

Move hardcoding out of previous patch to lang/mono/Makefile into Mk/bsd.default-versions.mk
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-12-18 05:45:43 UTC
A commit references this bug:

Author: linimon
Date: Fri Dec 18 05:45:04 UTC 2020
New revision: 558353
URL: https://svnweb.freebsd.org/changeset/ports/558353

Log:
  Define new value MONO_DEFAULT.  Not yet used in ports tree (WIP).

  PR:		251795
  Submitted by:	linimon

Changes:
  head/Mk/bsd.default-versions.mk
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-12-18 19:38:20 UTC
A commit references this bug:

Author: linimon
Date: Fri Dec 18 19:37:25 UTC 2020
New revision: 558400
URL: https://svnweb.freebsd.org/changeset/ports/558400

Log:
  Add proper CONFLICTS_INSTALL.

  These should now be complete and ready for wider testing, so change the
  maintainers to all be mono@FreeBSD.org

  PR:		251795
  Submitted by:	linimon

Changes:
  head/lang/mono5.10/Makefile
  head/lang/mono5.20/Makefile
  head/lang/mono6.8/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-12-18 19:41:30 UTC
A commit references this bug:

Author: linimon
Date: Fri Dec 18 19:40:49 UTC 2020
New revision: 558401
URL: https://svnweb.freebsd.org/changeset/ports/558401

Log:
  Hook the repocopied and updated mono ports to the build.

  PR:		238089, 251795
  Submitted by:	cem (238089)

Changes:
  head/lang/Makefile
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2020-12-18 19:47:02 UTC
The content of attachment 220653 [details] has been deleted for the following reason:

OBE by r558353, r558402.  (I cannot find a way for Bugzilla to simply "obsolete" it.)
Comment 7 Dries Michiels freebsd_committer freebsd_triage 2020-12-20 11:29:01 UTC
Hi Mark,

I'm so happy that you picked up this work around mono!
So from this commit on, we can use mono=6.8 in DEFAULT_VERSIONS in make.conf?

Thanks for the feedback!
Comment 8 Mark Linimon freebsd_committer freebsd_triage 2020-12-20 13:38:05 UTC
(In reply to Dries Michiels from comment #7)

Well it hasn't been committed yet (it still needs testers!) but that is the intention, yes.  I have run it here on my own system and changed the default to the various choices and then re-run the dependent ports.

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238089#c75 for the dependent ports that regress.  (So far, no one has commented on that).
Comment 9 Ulrich Spörlein freebsd_committer freebsd_triage 2021-04-03 08:11:47 UTC
I see that you marked the broken ports as such, can we thus move forward with upgrading the default version to 5.20 (or 6.8?)

Maybe do that after the quarterly branch. What would it take?
Comment 10 commit-hook freebsd_committer freebsd_triage 2021-05-25 02:50:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=411aa79977ad64f430a29ed6c2f1065a7399bb25

commit 411aa79977ad64f430a29ed6c2f1065a7399bb25
Author:     Mark Linimon <linimon@FreeBSD.org>
AuthorDate: 2021-05-14 18:56:40 +0000
Commit:     Mark Linimon <linimon@FreeBSD.org>
CommitDate: 2021-05-25 02:46:58 +0000

    lang/mono: convert to metaport.

    PR:             251795

 lang/mono/Makefile | 92 +++++-------------------------------------------------
 1 file changed, 7 insertions(+), 85 deletions(-)
Comment 11 Gleb Popov freebsd_committer freebsd_triage 2021-09-25 11:28:02 UTC
This seems to be committed. Can we close the PR?
Comment 13 commit-hook freebsd_committer freebsd_triage 2023-08-08 11:22:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6c225bcc570ece3af3d61d497330b79c912c60ef

commit 6c225bcc570ece3af3d61d497330b79c912c60ef
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-08 10:37:41 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-08-08 11:22:05 +0000

    lang/mono: respect MONO_DEFAULT in consumers

    PR:             251795

 Mk/Uses/mono.mk                             | 4 ++--
 deskutils/cairo-dock-plugins/Makefile       | 4 ++--
 devel/dbus-sharp/Makefile                   | 2 +-
 devel/log4net/Makefile                      | 2 +-
 devel/mono-addins/Makefile                  | 2 +-
 devel/msbuild/Makefile                      | 1 +
 devel/nant/Makefile                         | 2 +-
 devel/ndesk-dbus-glib/Makefile              | 2 +-
 devel/ndesk-dbus/Makefile                   | 2 +-
 devel/ndesk-options/Makefile                | 2 +-
 devel/newtonsoft-json/Makefile              | 2 +-
 devel/nini/Makefile                         | 2 +-
 devel/notify-sharp/Makefile                 | 1 +
 devel/simian/Makefile                       | 2 +-
 editors/bless/Makefile                      | 2 +-
 emulators/mesen/Makefile                    | 6 +++---
 games/gbrainy/Makefile                      | 1 +
 games/openbve/Makefile                      | 1 +
 games/openclaw/Makefile                     | 2 +-
 games/openra/Makefile                       | 2 +-
 graphics/nplot/Makefile                     | 2 +-
 graphics/pinta/Makefile                     | 2 +-
 irc/smartirc4net/Makefile                   | 2 +-
 irc/smuxi/Makefile                          | 2 +-
 lang/fsharp/Makefile                        | 1 +
 lang/mono-basic/Makefile                    | 1 +
 misc/gedkeeper/Makefile                     | 1 +
 net/avahi-sharp/Makefile                    | 2 +-
 net/ntpa/Makefile                           | 2 +-
 security/gnome-keyring-sharp/Makefile       | 2 +-
 security/keepass-plugin-keepassrpc/Makefile | 1 +
 security/keepass/Makefile                   | 1 +
 www/mod_mono/Makefile                       | 1 +
 www/xsp/Makefile                            | 1 +
 x11-toolkits/gtk-sharp20/Makefile           | 2 +-
 x11-toolkits/gtk-sharp30/Makefile           | 2 +-
 36 files changed, 40 insertions(+), 29 deletions(-)
Comment 14 commit-hook freebsd_committer freebsd_triage 2023-08-10 10:41:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4553130a9c53d463091301110ccd3d8854a9fe58

commit 4553130a9c53d463091301110ccd3d8854a9fe58
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-10 09:55:00 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-08-10 10:39:09 +0000

    lang/mono: convert to a meta port after 6c225bcc570e

    - Removing everything in favor of RUN_DEPENDS
    - Add QA check to prevent future consumers

    PR:             251795

 Mk/Scripts/qa.sh                                   |    3 +
 lang/mono/Makefile                                 |  105 +-
 lang/mono/distinfo (gone)                          |    5 -
 .../extra-patch-aarch64-race-workaround (gone)     |   26 -
 lang/mono/files/patch-configure.ac (gone)          |   76 -
 ...nal_boringssl_crypto_cpu-aarch64-linux.c (gone) |   42 -
 ...urity.Cryptography_KeyPairPersistence.cs (gone) |   11 -
 ...y_Mono.Security.X509_X509StoreManager.cs (gone) |   20 -
 ...uration.Crypto_KeyContainerCollection.cs (gone) |   11 -
 ...build_data_12.0_Microsoft.CSharp.targets (gone) |   25 -
 ...build_data_14.0_Microsoft.CSharp.targets (gone) |   25 -
 .../files/patch-mono_eglib_gfile-posix.c (gone)    |   11 -
 lang/mono/files/patch-mono_mini_driver.c (gone)    |   21 -
 .../files/patch-mono_mini_exceptions-ppc.c (gone)  |   11 -
 lang/mono/files/patch-mono_mini_mini-ppc.c (gone)  |   20 -
 lang/mono/files/patch-mono_mini_mini-x86.h (gone)  |   11 -
 .../files/patch-mono_mini_tramp-amd64.c (gone)     |   26 -
 .../files/patch-mono_sgen_sgen-archdep.h (gone)    |   11 -
 .../files/patch-mono_utils_mono-context.h (gone)   |   42 -
 .../files/patch-mono_utils_mono-proclib.c (gone)   |   10 -
 .../patch-mono_utils_mono-sigcontext.h (gone)      |   31 -
 .../files/patch-mono_utils_mono-threads.c (gone)   |   20 -
 lang/mono/files/patch-scripts_mono-heapviz (gone)  |   11 -
 lang/mono/pkg-message (gone)                       |   37 -
 lang/mono/pkg-plist (gone)                         | 2984 --------------------
 lang/mono/pkg-plist.aarch64 (gone)                 | 2945 -------------------
 lang/mono/pkg-plist.powerpc (gone)                 | 2980 -------------------
 27 files changed, 8 insertions(+), 9512 deletions(-)
Comment 15 commit-hook freebsd_committer freebsd_triage 2023-08-10 10:54:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=959d0e922c3c5873e9eadf6e801ce13ca4f6d217

commit 959d0e922c3c5873e9eadf6e801ce13ca4f6d217
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-10 10:51:57 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-08-10 10:54:21 +0000

    lang/mono: restore WWW after 4553130a9c53

    PR:             251795

 lang/mono/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 16 commit-hook freebsd_committer freebsd_triage 2023-08-10 11:07:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e08306048a962e992aab15f59ae5bca820a1d1c2

commit e08306048a962e992aab15f59ae5bca820a1d1c2
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-10 10:51:57 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-08-10 11:05:51 +0000

    lang/mono: restore MAINTAINER after 4553130a9c53

    PR:             251795

 lang/mono/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 17 Jan Beich freebsd_committer freebsd_triage 2023-08-10 11:09:35 UTC
*** Bug 258956 has been marked as a duplicate of this bug. ***