Created attachment 220719 [details] Version bump net/asterisk-chan_sccp: Version bump to v4.3.3 - removal of patch files
Thanks, I'm going to test it.
Why did you remove USES=ssl and LIB_DEPENDS=libltdl.so:devel/libltdl? Both are actually required, since the binary does link to them. From my podriere build log: ====> Running Q/A tests (stage-qa) Warning: you need USES=ssl Error: /usr/local/lib/asterisk/modules/chan_sccp.so is linked to /usr/local/lib/libiconv.so.2 from converters/libiconv but it is not declared as a dependency Warning: you need USES+=iconv, USES+=iconv:wchar_t, or USES+=iconv:translit depending on needs Error: /usr/local/lib/asterisk/modules/chan_sccp.so is linked to /usr/local/lib/libltdl.so.7 from devel/libltdl but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libltdl.so:devel/libltdl ====> Checking for pkg-plist issues (check-plist) [...] =========================================================================== =>> Checking shared library dependencies 0x0000000000000001 NEEDED Shared library: [libBlocksRuntime.so.0] 0x0000000000000001 NEEDED Shared library: [libc.so.7] 0x0000000000000001 NEEDED Shared library: [libcrypto.so.111] 0x0000000000000001 NEEDED Shared library: [libexecinfo.so.1] 0x0000000000000001 NEEDED Shared library: [libiconv.so.2] 0x0000000000000001 NEEDED Shared library: [libltdl.so.7] 0x0000000000000001 NEEDED Shared library: [libm.so.5] 0x0000000000000001 NEEDED Shared library: [libssl.so.111] 0x0000000000000001 NEEDED Shared library: [libthr.so.3] =======================<phase: deinstall >============================ ===> Deinstalling for asterisk16-chan_sccp (not sure why it tells me about iconv too, since USES=iconv is present, so I'll count that as a false positive) The rule is any dependency required at run time, even if indirect should be declared. I'm asking information before adding them myself.
I also noticed you removed the stanza: .if ${FLAVOR} == asterisk13 CONFIGURE_ARGS+= --with-asterisk-version=13 .elif ${FLAVOR} == asterisk16 CONFIGURE_ARGS+= --with-asterisk-version=16 .elif ${FLAVOR} == asterisk18 CONFIGURE_ARGS+= --with-asterisk-version=18 .endif While it is not strictly needed at present, I'd rather keep it. It does no harm!
Ooh scrap that. That was not my intention at all. I just ran portsnap fetch/portsnap update and based my changes on that. My intent was only to remove all the patch files and just change the version number. My patch is no good at all. I should have inspected it a little closer before pushing it.
I will redo this patch tomorrow. Sorry for the inconvenience.
(In reply to Diederik de Groot from comment #4) > Ooh scrap that. That was not my intention at all. I just ran portsnap > fetch/portsnap update and based my changes on that. My intent was only to > remove all the patch files and just change the version number. My patch is no > good at all. I should have inspected it a little closer before pushing it. BTW portsnap has been deprecated, but I think it still provides current sources. You'd better use subversion for the time being (subversion will be replaced by git in a few months too, but at present subversion is still the official source of truth.)
I also noticed, your patch remove files/patch-src_define.h. I think that's also a mistake, because that was added to fix it on FreeBSD big endian archs, I think that patch file should be kept.
@Guido, If you have time and access to a running system and the latest sources, can you try to make the change i wanted to do. I have done a release of v4.3.3 today, my plan was only to change that. I will try to be a little more carefull next time. If you don't have time i will make the switch back to svn and do the patching myself. Thanks
Created attachment 220725 [details] Manually edited patch This might already be enough.
(In reply to Diederik de Groot from comment #9) Thanks I think this is fine, I'll test it and commit it.
Thanks, Note i manually edited the diff on linux so could not run any test. But it looks ok afaict
A commit references this bug: Author: madpilot Date: Sat Dec 19 23:14:13 UTC 2020 New revision: 558703 URL: https://svnweb.freebsd.org/changeset/ports/558703 Log: Update asterisk-chan_sccp to v4.3.3 PR: 251962 Submitted by: Diederik de Groot <ddegroot@talon.nl> (maintainer) Changes: head/net/asterisk-chan_sccp/Makefile head/net/asterisk-chan_sccp/distinfo
Committed. My request were for clarifications. If a maintainer removes a dependency I try to understand why, his reasons, before overriding him. Did not mean to sound aggressive. Thanks!
Thanks Guido for paying more attention then me and noticing my initial mistake