Bug 251981 - misc/broot: Update to 1.0.9
Summary: misc/broot: Update to 1.0.9
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Juraj Lutter
URL: https://github.com/canop/broot/releas...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-20 12:20 UTC by Lewis Cook
Modified: 2020-12-25 14:45 UTC (History)
1 user (show)

See Also:
lcook: merge-quarterly?

Attachments
broot-1.0.9.diff (42.10 KB, patch)
2020-12-20 12:20 UTC, Lewis Cook 		lcook: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Cook freebsd_committer freebsd_triage 2020-12-20 12:20:03 UTC 
Created attachment 220743 [details]
broot-1.0.9.diff

* Fixes configuration file quotation bug[1]
  seen in 1.0.7 and upwards. This has been
  addressed in the latest release, 1.0.9.

[1] https://github.com/Canop/broot/issues/316 

Changelog:

 * https://github.com/canop/broot/releases/v1.0.9

QA:

 * portlint: OK (looks fine).
 * testport: OK (poudriere: 12.2-RELEASE, amd64).

MFH: Yes (Bugfix release, merge to quarterly branch).
Comment 1 Juraj Lutter freebsd_committer freebsd_triage 2020-12-21 18:22:13 UTC 
review D27701
Comment 2 Juraj Lutter freebsd_committer freebsd_triage 2020-12-25 12:56:49 UTC 
(In reply to Lewis Cook from comment #0)
Please set maintainer-feedback to + if the patch is OK to commit.

For me it built and worked.
Comment 3 Lewis Cook freebsd_committer freebsd_triage 2020-12-25 13:14:32 UTC 
(In reply to Juraj Lutter from comment #2)
That's not required. Only in the circumstances I wasn't the maintainer of this port then would I require the maintainer-feedback+ flag. Otherwise, setting maintainer-approval+ of the attachment is sufficient enough in this case. :-)

https://wiki.freebsd.org/Bugzilla/ThePerfectPortsIssue is a good for this.

Cheers!
Comment 4 Lewis Cook freebsd_committer freebsd_triage 2020-12-25 13:15:32 UTC 
(In reply to Lewis Cook from comment #3)
s/good/good resource/.
Comment 5 Juraj Lutter freebsd_committer freebsd_triage 2020-12-25 13:19:14 UTC 
(In reply to Lewis Cook from comment #3)
Fair enough! :-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-12-25 14:45:19 UTC 
A commit references this bug:

Author: otis
Date: Fri Dec 25 14:44:51 UTC 2020
New revision: 559246
URL: https://svnweb.freebsd.org/changeset/ports/559246

Log:
  misc/broot: Update to 1.0.9

  Fixes configuration file quotation bug seen in 1.0.7 and upwards.

  Changelog:
  https://github.com/canop/broot/releases/v1.0.9

  PR:		251981
  Submitted by:	Lewis Cook <vulcan@wired.sh> (maintainer)
  Reviewed by:	osa (mentor)
  Approved by:	osa (mentor)
  Differential Revision:	https://reviews.freebsd.org/D27701

Changes:
  head/misc/broot/Makefile
  head/misc/broot/distinfo
  head/misc/broot/files/patch-src_display_cell__size.rs