Created attachment 221077 [details] git(1) diff against the ports tree libgnuregex has been removed in -CURRENT. Switch to using the newer version that's provided in ports as of ports r559542.
Comment on attachment 221077 [details] git(1) diff against the ports tree Thanks, Kyle!
^Triage: Reporter is committer, assign accordingly. Q/A: Makefile: COMMENT is not supposed to begin with 'A ', 'An ', or 'The '. /tmp/252258/www/spreadlogd/files/patch-config.h: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. /tmp/252258/www/spreadlogd/files/patch-makefile: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. /tmp/252258/www/spreadlogd/files/patch-spreadlogd.c: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. Thanks!
(In reply to Fernando Apesteguía from comment #2) All of the patches created in files were created eith diff(1) and work at least as well intended as anything that uses makepatch, which also uses diff(1). I'll address the COMMENT "nit" shortly. :-)
Created attachment 221114 [details] svn diff for www/spreadlogd version 2 Changes addressing comment #2 This should do it. :-) --Chris
(In reply to Chris Hutchinson from comment #4) Sorry for the delay on this -- AFAICT the package version test format isn't valid for LIB_DEPENDS: ===> Applying FreeBSD patches for spreadlogd-1.4.2 from /usr/local/poudriere/ports/default/www/spreadlogd/files Error: pattern libgnuregex>5 in LIB_DEPENDS is not valid I think I'm going to look at patching portlint to squelch the warning that change was addressing specifically for this lib in the form of a general "lib competing with base" list kind of thing. We do similar shenanigans with, e.g., openssl to make sure we don't use the base version if the ports version has been selected.
A commit references this bug: Author: danfe Date: Thu Jan 21 09:29:38 UTC 2021 New revision: 562184 URL: https://svnweb.freebsd.org/changeset/ports/562184 Log: - Fix the build on recent -CURRENT by depending on `devel/libgnuregex' - Drop the leading article from the COMMENT line per our conventions - Install docfiles in the dedicated `do-install-DOCS-on' helper target - Wrap an overly long line and reduce vertical whitespace while here PR: 252258 Submitted by: kevans Changes: head/www/spreadlogd/Makefile
Committed along with minor cleanups as ports r562184, thanks.
This needs to be merged to quarterly. pkg-fallout continues to complain. Please merge Quarterly. Thanks! :-)