Bug 252271 - math/superlu: Fetch failed
Summary: math/superlu: Fetch failed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-29 18:02 UTC by Guangyuan Yang
Modified: 2021-01-01 17:38 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (robert.ayrapetyan)


Attachments
patch with working MASTER_SITES and update to 5.2.2 (18.95 KB, patch)
2020-12-31 10:51 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guangyuan Yang freebsd_committer freebsd_triage 2020-12-29 18:02:29 UTC
Trying to build math/superlu as a dependency, log: 

https://poudriere.ygy.io/data/122Ramd64-development/2020-12-29_17h40m04s/logs/errors/superlu-5.2.1_11.log
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2020-12-30 11:38:19 UTC
Hmm, I just tried and for me 'make fetch' works as expected :)


There is a Github page https://github.com/xiaoyeli/superlu, with a newer release v5.2.2 from October. Perhaps an update would be fine?
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-30 18:44:25 UTC
^Triage: Reporter is committer, assign accordingly.

Seems to fetch only from our distfiles cache:

===>  License BSD3CLAUSE accepted by the user
===>   superlu-5.2.1_11 depends on file: /usr/local/sbin/pkg - found
=> superlu_5.2.1.tar.gz doesn't seem to exist in /data/fernape_data/FreeBSD-repos/ports/head/distfiles/superlu.
=> Attempting to fetch http://crd-legacy.lbl.gov/~xiaoye/SuperLU/superlu_5.2.1.tar.gz
superlu_5.2.1.tar.gz                                  2500 kB  936 kBps    03s
=> SLU_general.ps.gz doesn't seem to exist in /data/fernape_data/FreeBSD-repos/ports/head/distfiles/superlu.
=> Attempting to fetch http://crd-legacy.lbl.gov/~xiaoye/SLU_general.ps.gz
fetch: http://crd-legacy.lbl.gov/~xiaoye/SLU_general.ps.gz: Not Found
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/superlu/SLU_general.ps.gz
SLU_general.ps.gz                                       87 kB 2372 kBps    00s
=> simax-29176.pdf doesn't seem to exist in /data/fernape_data/FreeBSD-repos/ports/head/distfiles/superlu.
=> Attempting to fetch http://crd-legacy.lbl.gov/~xiaoye/simax-29176.pdf
fetch: http://crd-legacy.lbl.gov/~xiaoye/simax-29176.pdf: Not Found
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/superlu/simax-29176.pdf
simax-29176.pdf                                        509 kB 1450 kBps    01s
===> Fetching all distfiles required by superlu-5.2.1_11 for building
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2020-12-31 10:51:45 UTC
Created attachment 221127 [details]
patch with working MASTER_SITES and update to 5.2.2

Fernando correctly states in comment #2 that the current port only gets its sources from the distfiles cache, sorry.

The attached patch uses the current, working URL from X. Sherry Li's page (xiaoyeli). I also took the opportunity to include the update to version 5.2.2. Additionally the patch contains the following changes:

- Add USES=pkgconfig
- Remove PLIST_SUB (not needed)
- Update WRKSRC
- Include EXAMPLES (also Fortran examples)
- Also download the technical report, which describes
  the implemented ILU algorithm
- Update files/patch-SRC_CMakeLists.txt
- Update pkg-plist


Tested on Poudriere (amd64, i386). 'portlint -AC' is ok.
Comment 4 Guangyuan Yang freebsd_committer freebsd_triage 2020-12-31 17:19:35 UTC
(In reply to Rainer Hurling from comment #3)

That looks good to me, please commit the change, thanks! Shall we wait for the maintainer, or is it covered by the portmgr blanket?
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-31 17:23:03 UTC
Excellent work. 

Just a minor issue: WRKSRC after CMAKE_*
Comment 6 Rainer Hurling freebsd_committer freebsd_triage 2020-12-31 17:28:53 UTC
Thanks to you both for your feedback :)

AFAIK a portmgr blanket would be only for fixing the breakage with MASTER_SITES, not for the update and other changes.

I would expect we have to wait for the maintainer approval?
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-31 17:49:37 UTC
(In reply to Rainer Hurling from comment #6)
In normal conditions we would wait an undetermined amount of time (around 1 week minumum) but since the fetch problem makes the port useless, I would fix it right away.
Comment 8 Rainer Hurling freebsd_committer freebsd_triage 2020-12-31 17:53:49 UTC
(In reply to Fernando Apesteguía from comment #7)
Ok, so now I'm going to write a review in Phabricator since I'm a mentored committer.
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-01-01 15:28:50 UTC
A commit references this bug:

Author: rhurlin
Date: Fri Jan  1 15:27:56 UTC 2021
New revision: 559838
URL: https://svnweb.freebsd.org/changeset/ports/559838

Log:
  math/superlu: Fix mastersite and update to 5.2.2

  Fix MASTER_SITES, update and rework the port.

  Changelog: https://portal.nersc.gov/project/sparse/superlu/changes.html#slu_change

  PR:		252271
  Reported by:	Guangyuan Yang <ygy@freebsd.org>
  Approved by:	arrowd (mentor)
  Differential Revision:	https://reviews.freebsd.org/D27868

Changes:
  head/math/superlu/Makefile
  head/math/superlu/distinfo
  head/math/superlu/files/patch-SRC_CMakeLists.txt
  head/math/superlu/pkg-descr
  head/math/superlu/pkg-plist
Comment 10 Rainer Hurling freebsd_committer freebsd_triage 2021-01-01 15:31:22 UTC
Committed before maintainer approval because of the needed fix of MASTER_SITES, see also https://reviews.freebsd.org/D27868.
Comment 11 Guangyuan Yang freebsd_committer freebsd_triage 2021-01-01 17:38:51 UTC
(In reply to Rainer Hurling from comment #10)

Thank you both Rainer and Fernando!