Bug 252341 - net/libilbc: Update to 3.0.4 & Adopt port
Summary: net/libilbc: Update to 3.0.4 & Adopt port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Fernando Apesteguía
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-01-02 03:20 UTC by Neel Chauhan
Modified: 2021-01-03 17:50 UTC (History)
3 users (show)

See Also:

Attachments
Patch (Revision 1) (2.75 KB, patch)
2021-01-02 03:20 UTC, Neel Chauhan 		no flags Details | Diff
New patch for maintainer and dist update only (1.11 KB, patch)
2021-01-03 13:43 UTC, Fernando Apesteguía 		no flags Details | Diff
post-patch Fixed (1.27 KB, patch)
2021-01-03 14:32 UTC, Fernando Apesteguía 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2021-01-02 03:20:13 UTC 
Created attachment 221187 [details]
Patch (Revision 1)

Passes poudriere.
Comment 1 Automation User 2021-01-02 03:37:20 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/236501341
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-01-02 07:47:44 UTC 
Hi Neel,

Please use release archive found here:
https://github.com/TimothyGu/libilbc/releases/tag/v3.0.4 (tar.gz)
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2021-01-02 11:32:33 UTC 
(In reply to daniel.engberg.lists from comment #2)
Why should the release archive be used instead ?
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2021-01-02 12:03:04 UTC 
(In reply to Kurt Jaeger from comment #3)
"If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file"...
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description

This is mainly avoid silently re-rolled archives as they're generated on the fly but in general there are also other potential benefits such as not needing to use autoreconf (autotools only), potentially better availability since it's a static file and overall consistency to mention a few.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-03 13:43:31 UTC 
Created attachment 221241 [details]
New patch for maintainer and dist update only

I already updated this port in ports r559962 when it was reported by portscout.

I update a new patch that uses the dist file and updates maintainer.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-03 14:32:02 UTC 
Created attachment 221243 [details]
post-patch Fixed

Fixed patch
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-03 17:49:32 UTC 
Committed,

Thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-01-03 17:50:16 UTC 
A commit references this bug:

Author: fernape
Date: Sun Jan  3 17:49:21 UTC 2021
New revision: 560026
URL: https://svnweb.freebsd.org/changeset/ports/560026

Log:
  net/libilbc: set new MAINTAINER

  Submitter becomes maintainer. He also maintains several ports.

  Use release archive.

  PR:	252341
  Submitted by:	neel@neelc.org

Changes:
  head/net/libilbc/Makefile
  head/net/libilbc/distinfo