Bug 252571 - security/suricata: simplify Makefile
Summary: security/suricata: simplify Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-11 10:01 UTC by Fernando Apesteguía
Modified: 2021-01-20 14:08 UTC (History)
1 user (show)

See Also:
franco: maintainer-feedback+

Attachments
patch to the ports tree (4.95 KB, patch)
2021-01-11 10:01 UTC, Fernando Apesteguía 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-11 10:01:04 UTC 
Created attachment 221451 [details]
patch to the ports tree

As it was discussed in bug #251887 the patch does some improvements in the port's Makefile.

This add USES=localbase so we can get rid of *-includes and *-libraries.
Reorder some variables too.

I did some light testing and change some options and seems to build fine in {11.4,12.2}{amd64,i386} and 13-current amd64.
Comment 1 Franco Fichtner 2021-01-20 12:29:15 UTC 
Hi Fernando,

The whitespace change in post-patch-PYTHON-on does not look alright, although it is a line continuation it should better be a TAB at the beginning of the line like it used to to conform to makefile syntax.

Otherwise works fine from what I can tell.


Thanks,
Franco
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-20 12:37:41 UTC 
(In reply to Franco Fichtner from comment #1)

I don't know where those spaces came from :-)

Sorry for that. I will commit the fixed version.

Thanks!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-20 14:02:33 UTC 
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-01-20 14:02:48 UTC 
A commit references this bug:

Author: fernape
Date: Wed Jan 20 14:02:18 UTC 2021
New revision: 562136
URL: https://svnweb.freebsd.org/changeset/ports/562136

Log:
  security/suricata: simplify Makefile

  Add USES=localbase so we can get rid of *-includes and *-libraries.
  Reorder some variables too.
  Regenerate patch.

  PR:	252571
  Submitted by:	fernape@FreeBSD.org
  Reviewed by:	franco@opnsense.org (maintainer)

Changes:
  head/security/suricata/Makefile
  head/security/suricata/files/patch-src_suricata-common.h
Comment 5 Franco Fichtner 2021-01-20 14:08:16 UTC 
Nice, thank you.  :)