Bug 252577 - security/wpa_supplicant: can't build with EAPOL_TEST and LLVM 10
Summary: security/wpa_supplicant: can't build with EAPOL_TEST and LLVM 10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-11 15:05 UTC by David Siebörger
Modified: 2021-03-17 19:26 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
poudriere build log (181.28 KB, text/plain)
2021-01-11 15:05 UTC, David Siebörger 		no flags Details
Fix (928 bytes, patch)
2021-01-11 16:37 UTC, Cy Schubert 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Siebörger 2021-01-11 15:05:39 UTC 
Created attachment 221459 [details]
poudriere build log

The patch added in revision 559639 breaks building security/wpa_supplicant when the EAPOL_TEST option is enabled and LLVM 10 is in use.  Manually removing files/patch-src_radius_radius__client.c allows the build to proceed, but I'm afraid I'm not sure how the patch could be made conditional on LLVM 11.

I've attached a poudriere build log.
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2021-01-11 16:14:11 UTC 
uname -a please.
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2021-01-11 16:37:07 UTC 
Created attachment 221469 [details]
Fix

Try this.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-01-12 04:28:06 UTC 
A commit references this bug:

Author: cy
Date: Tue Jan 12 04:27:17 UTC 2021
New revision: 561297
URL: https://svnweb.freebsd.org/changeset/ports/561297

Log:
  Fix build on llvm10 and gcc.

  PR:		252577
  Reported by:	David Sieborger <drs-freebsd _ sieborger.nom.za>
  MFH:		2021Q1

Changes:
  head/security/wpa_supplicant/files/patch-src_radius_radius__client.c
Comment 4 David Siebörger 2021-01-12 06:25:49 UTC 
I've confirmed that the solution works here.  Thanks very much for fixing that so quickly.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-03-17 19:26:53 UTC 
A commit references this bug:

Author: cy
Date: Wed Mar 17 19:26:42 UTC 2021
New revision: 568684
URL: https://svnweb.freebsd.org/changeset/ports/568684

Log:
  MFH: r561297

  Fix build on llvm10 and gcc.

  PR:		252577
  Reported by:	David Sieborger <drs-freebsd _ sieborger.nom.za>

Changes:
_U  branches/2021Q1/
  branches/2021Q1/security/wpa_supplicant/files/patch-src_radius_radius__client.c