Created attachment 221476 [details] patch for new version Update datadog-integrations to the latest 7.24.0
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. ^Triage: Maintainer-feedback flag (+) not required unless requested (?) first. Q/A: Some small improvements to the Makefile: # USES block USES +USE_GITHUB +GH_ACCOUNT +GH_PROJECT +GH_TAGNAME # Standard bsd.port.mk variables ETCDIR +NO_ARCH +NO_BUILD # Users and groups block USERS GROUPS -USE_GITHUB -GH_ACCOUNT -GH_PROJECT -GH_TAGNAME -NO_BUILD -NO_ARCH Thanks!
There is no changelog avialable from their site. And with port I mainly just increased version number. Should I do the change in Makefile and update patch file? Sorry if I ask such questions but I'm ferly new to this processes.
(In reply to uros from comment #2) No need to apologize! If there is no changelog, it is OK. Thanks for checking that. Yes, please, it would be great if you could make the changes. Have a look at: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-order You can use ports-mgmt/portfmt and ports-mgmt/portlint to double check your ports :-) Thanks!
Created attachment 221557 [details] Fixed formating Please check with this patch. Should be all good now.
(In reply to uros from comment #4) Almost done. # Standard bsd.port.mk variables ETCDIR +NO_ARCH NO_BUILD -NO_ARCH :-)
Created attachment 221558 [details] format changes
(In reply to uros from comment #6) Thanks
Just checking if there is anything else I need to fix?
(In reply to uros from comment #8) LGTM, good jon! Wait for a committer to pick it up
A commit references this bug: Author: kai Date: Sat Mar 6 12:05:30 UTC 2021 New revision: 567483 URL: https://svnweb.freebsd.org/changeset/ports/567483 Log: sysutils/datadog-integrations: Update to 7.24.0 * Also sort some variables according the PHB and fix indents. Changelog: https://github.com/DataDog/integrations-core/blob/7.24.0/AGENT_CHANGELOG.md PR: 252593 Submitted by: Uro? Gruber (maintainer) Reviewed by: fernape Changes: head/sysutils/datadog-integrations/Makefile head/sysutils/datadog-integrations/distinfo head/sysutils/datadog-integrations/pkg-plist
Committed, thank you both for the patch and the review! I did some additional fixes to the pkg-plist to avoid build failures if built with all options set.