Bug 252601 - games/devilutionX: fix empty "Show Credits" window
Summary: games/devilutionX: fix empty "Show Credits" window
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-01-12 08:40 UTC by Nuno Teixeira
Modified: 2021-01-16 17:02 UTC (History)
1 user (show)

See Also:

Attachments
Sugested git diff (630 bytes, patch)
2021-01-12 08:40 UTC, Nuno Teixeira 		eduardo: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2021-01-12 08:40:02 UTC 
Created attachment 221485 [details]
Sugested git diff

Fix empty "Show Credits" window:
INFO: TTF_OpenFont: Couldn't open CharisSILB.ttf

TTF_FONT_PATH was introduced in tag 1.0.1 to 1.0.3.
1.1.0 changed from TTF_FONT_PATH to TTF_FONT_DIR/TTF_FONT_NAME.

(Based on inspecting CMakeLists.txt in all tags available)

Thanks,

Nuno Teixeira
Comment 1 Automation User 2021-01-12 08:59:23 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/240376365
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2021-01-16 15:39:41 UTC 
I bumped PORTREVISION. Did I did it right? Don't know who decides that, a commiter perhaps?

Thanks
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2021-01-16 16:45:02 UTC 
(In reply to Nuno Teixeira from comment #2)

I think you are right to bump portrevision, because the credits window becomes functional again.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-01-16 17:00:51 UTC 
A commit references this bug:

Author: rhurlin
Date: Sat Jan 16 17:00:07 UTC 2021
New revision: 561738
URL: https://svnweb.freebsd.org/changeset/ports/561738

Log:
  games/devilutionX: fix empty credits window

  Fix empty "Show Credits" window by changing TTF_FONT_PATH
  to TTF_FONT_DIR/TTF_FONT_NAME, introduced in v1.1.0 [1].

  [1] https://github.com/diasurgical/devilutionX/commit/791aa60cab453899dfaa7456cde1e8c23fcbee79

  PR:		252601
  Submitted by:	Nuno Teixeira <ed.arrakis@gmail.com> (maintainer)
  Approved by:	arrowd, tcberner (mentors, implicit)

Changes:
  head/games/devilutionX/Makefile
Comment 5 Rainer Hurling freebsd_committer freebsd_triage 2021-01-16 17:02:03 UTC 
Committed, thanks :)