Created attachment 221805 [details] poudriere build log for dahdi-kmod26 on 12.2 So... neither of these two ports compile. I've attached the poudriere build log to this ticket. If you examine the file GpakApi.c with an editor that treats a TAB as 8 spaces, you'll see quite a bit of indention madness. If you squint, however, it all makes sense at TAB as 4 spaces. The simplest fix for this port is to remove the -Wmisleading-indentation from the compile. How is that done?
Adding some detail: This compiles on 12.1 (and fails on 12.2). I'm not yet sure if -Wmisleading-indentation was inserted in between (in, say, ports.mk or somesuch).
Created attachment 221906 [details] patch for misc/dahdi-kmod
Created attachment 221907 [details] patch for misc/dahdi-kmod26
Patches fix things, checked on 12.1 and 12.2 In Short, turn off -Werror.
And if the maintainer wants out, I have an interest in maintaining this port as I'm using it.
Created attachment 229202 [details] Patch to fix indentation problem misc/dahdi-kmod26 is currently marked as BROKEN with "does not compile: use of undeclared identifier 'thread_dtor'." I just tried compiling it under 12.3-BETA2 with quarterly ports and the only issue I see is the indentation issue mentioned above. Instead of patching the Makefile to turn off -Werror I would just fix the one instance of the problem. See attached patch. It replaces a tab character with 4 spaces. After applying this patch the port compiles under 12.3-BETA2 and quarterly ports. Is the current BROKEN message valid for FreeBSD 13 or 14? It isn't for 12.
Created attachment 229205 [details] patch to fix BROKEN I just fired up a 13.0-RELEASE VM and dahdi-kmod26 is in fact BROKEN for 13. But the fix is easy, see attached patch (which should probably be a new bug report). There are also other errors which are easily dealt with by turning off -Werror. So I'd go with the Makefile patch instead of my patch to GpakApi.c.
Maintainer timeout (9 months)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2569669c0955d53caca83563325c13a791dbca5f commit 2569669c0955d53caca83563325c13a791dbca5f Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2021-11-09 21:03:55 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2021-11-10 10:54:51 +0000 misc/dahdi-kmod26: unbreak, change maintainer Unbreak build by adding missing header and disabling -Werror. Pass maintainership to submitter due to current maintainer inactivity. PR: 252907 Approved by: maintainer timeout (fjoe, 9 months) misc/dahdi-kmod26/Makefile | 6 ++---- misc/dahdi-kmod26/files/patch-drivers_dahdi_dahdi-base.c (new) | 10 ++++++++++ 2 files changed, 12 insertions(+), 4 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c5fa8f50683865bc13c56422b8dd0b199537102e commit c5fa8f50683865bc13c56422b8dd0b199537102e Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2021-11-09 21:06:51 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2021-11-10 10:55:06 +0000 misc/dahdi-kmod: partially unbreak, change maintainer Partially unbreak build by adding missing header and disabling -Werror. The remaining complete fix may be trivial but requires testing. Pass maintainership to submitter due to current maintainer inactivity. PR: 252907 Approved by: maintainer timeout (fjoe, 9 months) misc/dahdi-kmod/Makefile | 6 +++--- .../files/patch-freebsd-drivers-dahdi-dahdi-base.c | 18 +++++++++++++----- 2 files changed, 16 insertions(+), 8 deletions(-)
I've committed a fix for misc/dahdi-kmod26, and applied the same fix to misc/dahdi-kmod. As already mentioned, dahdi-kmod is not completely fixed yet, the new error is error: use of undeclared identifier 'SX_NOADAPTIVE' The fix would be trivial - just remove the usage of this flag. Not sure of implications though; if I've read the documentation correctly, the flag would disable adaptive spinning, which doesn't make much sense to me. misc/dahdi-kmod26 uses plain spinlock in this place. Anyway I'm attaching the patch for misc/dahdi-kmod, could anyone please test it?
Created attachment 229406 [details] Complete fix for dahdi-kmod
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=dec7dd55ef31e79d726c64b845dbea6f34c19b78 commit dec7dd55ef31e79d726c64b845dbea6f34c19b78 Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2021-11-10 11:29:56 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2021-11-10 11:30:07 +0000 misc/dahdi-kmod*: provide alive WWWs PR: 252907 misc/dahdi-kmod/pkg-descr | 2 +- misc/dahdi-kmod26/pkg-descr | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8aa4f0e63bc87d61ed3f2af3b6da5915a2a715ce commit 8aa4f0e63bc87d61ed3f2af3b6da5915a2a715ce Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2021-11-10 10:57:09 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2022-01-11 17:16:28 +0000 misc/dahdi-kmod: fix build PR: 252907 misc/dahdi-kmod/files/patch-include_dahdi_compat_bsd.h (new) | 11 +++++++++++ 1 file changed, 11 insertions(+)
The build fix for dahdi-kmod was committed (though still not tested), so closing this.
My build is successful both with and without the latest patch. I checked on three systems of version 12.3. On a real system, I get a kernel panic after loading one of the necessary modules. There is no such thing on two virtual hosts. I don't understand why yet, but everything worked on version 11.4. wctdm24xxp.ko module fails