Bug 252933 - textproc/libxml2: VALID as option name conflicts with framework
Summary: textproc/libxml2: VALID as option name conflicts with framework
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-23 07:50 UTC by Andrew "RhodiumToad" Gierth
Modified: 2021-02-12 20:28 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+
andrew: maintainer-feedback?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew "RhodiumToad" Gierth 2021-01-23 07:50:45 UTC 
The use of VALID as an option name conflicts with the framework as follows:

${opt}_CATEGORIES is an options helper that adds its content to CATEGORIES if the specified option is set

VALID_CATEGORIES is a framework variable containing the list of valid categories

So, if VALID_CATEGORIES is already defined at the point at which options are processed (which will be the case if local categories have been added via make.conf or Makefile.inc), the libxml2 package is labelled as belonging to every category.

Suggested fix: rename option VALID to VALIDATE or VALIDATION

(I did not find any other ports with this issue)
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-12 20:27:44 UTC 
Committed, thank you.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-02-12 20:28:22 UTC 
A commit references this bug:

Author: tcberner
Date: Fri Feb 12 20:27:37 UTC 2021
New revision: 565061
URL: https://svnweb.freebsd.org/changeset/ports/565061

Log:
  textproc/libxml2: rename VALID option to VALIDATION

  - The option name could under some circumctances lead to issues
    with the VALID_CATEGOIRES variable of the ports framework.
  - Simply rename the option, to something similar.

  PR:		252933
  Submitted by:	andrew@tao11.riddles.org.uk

Changes:
  head/textproc/libxml2/Makefile