Bug 253058 - games/gbrainy: adopt/update to 2.4.3
Summary: games/gbrainy: adopt/update to 2.4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-28 08:07 UTC by Nuno Teixeira
Modified: 2021-02-06 07:49 UTC (History)
2 users (show)

See Also:

Attachments
Sugested git diff (+DOCS, -NLS) (5.94 KB, patch)
2021-01-28 08:07 UTC, Nuno Teixeira 		eduardo: maintainer-approval-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2021-01-28 08:07:44 UTC 
Created attachment 221979 [details]
Sugested git diff (+DOCS, -NLS)

Hello,

games/gbrainy: Adopt and Update to 2.4.3 version

-Added DOCS: NEWS and README
-TODO: add NLS knob

Please don't commit yet, I'm looking for a solution for NLS @ ports

Thanks,

Nuno Teixeira
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2021-01-28 08:09:56 UTC 
and
-pet portclippy
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-01-28 10:40:59 UTC 
PORTVERSION --> DISTVERSION
RUN_DEPENDS:= --> RUN_DEPENDS=
Does it really need bash to run?
LOCALBASE lines can be replaced with USES= localbase and/or localbase:ldflags
Make sure it builds without www/gtkhtml3

Best regards,
Daniel
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2021-01-31 04:19:59 UTC 
Committed with changes.

Thank you for taking maintainership!
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-01-31 04:20:16 UTC 
A commit references this bug:

Author: yuri
Date: Sun Jan 31 04:19:54 UTC 2021
New revision: 563455
URL: https://svnweb.freebsd.org/changeset/ports/563455

Log:
  games/gbrainy: Update 2.2.2 -> 2.4.3

  ed.arrakis@gmail.com takes maintainership.

  PR:		253058
  Submitted by:	ed.arrakis@gmail.com

Changes:
  head/games/gbrainy/Makefile
  head/games/gbrainy/distinfo
  head/games/gbrainy/files/patch-Makefile.in
  head/games/gbrainy/files/patch-configure
  head/games/gbrainy/pkg-descr
  head/games/gbrainy/pkg-plist
Comment 5 Baptiste Daroussin freebsd_committer freebsd_triage 2021-02-06 07:03:57 UTC 
please have a look at:
https://svnweb.freebsd.org/ports?view=revision&revision=564191

This should have been catched before committing ;)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2021-02-06 07:49:05 UTC 
Thank you!

I completely forgot to check dependencies!

Nuno