Created attachment 221980 [details] Patch for existing port Hi All, New port version, the diff is attached. Pls commit this. Thanks
Created attachment 221981 [details] Patch for existing port (branch staging) Correct patch file
Created attachment 221986 [details] patch using github to access a commit between two versions Hi Sergey, Thanks for your patch. As far as I understand you want to use v5.10 with 3 additional versions from branch staging (#1c1fd41), right? For this, there is a good description in the Porters Handbook, example 19 [1]. It describes, how the concrete commit (tag) can be used to find a good version number. Here it is: # git describe --tags 1c1fd41 v5.10-3-g1c1fd41 This means, tag 1c1fd41 is three commit after v5.10. I changed the entries in your Makefile like this and created a new distinfo. While here, I also sorted the Makefile vars, like suggested by portclippy. Could you please have a look and give some feedback, if these changes are ok for you? [1] https://docs.freebsd.org/en/books/porters-handbook/#makefile-master_sites-github-ex5
(In reply to Rainer Hurling from comment #2) Hi Rainer, Thank you for the feedback and for the port improving. We discussed with fidogate developer the current version. The problem was in some user cases that had crashes. Needed fixes were made in the staging branch, but the developer believes that these fixes are not enough to create new release (too few changes), so this is a cause that me added link to the commit. Let me check your final version of the patch on my system. I'll send you report within 15 mins. Thanks
All looks fine, the patch was tested. The software looks good.
Thanks for your explanations and the tests. I just opened review D28400 on Phabricator, to get approval from my mentors.
A commit references this bug: Author: rhurlin Date: Thu Jan 28 15:08:42 UTC 2021 New revision: 563140 URL: https://svnweb.freebsd.org/changeset/ports/563140 Log: news/fidogate: Update to 5.10-3 Update port to release v5.10 [1] plus additional commits from branch 'staging' [2]. All commits after the release are fixes. - fidogate.service: [ is put back - fidogate.service: full paths for commands - rfc2ftn: fix mime unpacking if recipients given in command line - rfc2ftn: Fix SIGSEGV on list_free - mime: fix memleak on multipart decoding - rfc2ftn: Fix for test019: check crash in get_mime_disposition [1] https://github.com/ykaliuta/fidogate/releases/tag/v5.10 [2] https://github.com/ykaliuta/fidogate/commits/staging PR: 253059 Submitted by: Sergey Anokhin <admin@5034.ru> (maintainer) Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D28400 Changes: head/news/fidogate/Makefile head/news/fidogate/distinfo
Committed, thanks :)