Created attachment 222077 [details] Add upstream fix to "files/patch-lib_Smokeping.pm" Hello, I continue to migrate my services from Debian to FreeBSD. On Debian, I have smokeping 2.6.9 and it works well. On FreeBSD, I have smokeping 2.7.3 with the same configuration (nothing fancy), but I am having a problem: whenever a host is down, smokeping keeps sending alerts by email. It firsts send an email with this subjct: "[SmokeAlert] hostdown was raised on..." then every five minutes, it sends indefinitely this emails: "[SmokeAlert] hostdown was cleared on..." I've finally found it was a bug which was fixed upstream here: https://github.com/oetiker/SmokePing/commit/e9004e8bbeb30d33778afaf70a5f8b95ff38d6ba Here is the bug report for the smokeping project: https://github.com/oetiker/SmokePing/issues/183 and two others for Debian and Ubuntu: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934170 https://bugs.launchpad.net/ubuntu/+source/smokeping/+bug/1886584 I don't know why smokeping keeps being developed but there are no more releases after 2.7.3, which is from 2018... :-/ On FreeBSD, we already have patches in "files/patch-lib_Smokeping.pm", so I added the fix to this same patch file, I guess it is OK, since we are patching "lib/Smokeping.pm". I tried it with poudriere and now the behavior of smokeping is correct on my FreeBSD 12.2 server. Best Regards, Olivier
Hi, Thanks for the report, I will take a look at your patch and commit it accordingly. The Smokeping project is inactive since a while, and since the patch is not too big or complex, we can integrate it in the ports tree. I'll probably bump the upstream project and ask for a new release, sometimes it works ;) Regards, -- rodrigo
Hello Rodrigo, Thanks for your answer :-) The smokeping project isn't completely inactive, there are recents commits: https://github.com/oetiker/SmokePing/commits/master Yes, a new release would be nive after all this time. At least to fix this bug with alerts. Because without this patch, smokeping is useless for me. Best Regards, Olivier
A commit references this bug: Author: rodrigo Date: Tue Feb 2 08:14:07 UTC 2021 New revision: 563789 URL: https://svnweb.freebsd.org/changeset/ports/563789 Log: net-mgmt/smokeping: fix mail loop issue Integrate upstream patch[1] to fix mail loop issue #183[2]. This is a one-line patch without complexity who can be removed as soon as the upstream releases a new version. [1] https://github.com/oetiker/SmokePing/commit/e9004e8bbeb30d33778afaf70a5f8b95ff38d6ba [2] https://github.com/oetiker/SmokePing/issues/183 PR: 253161 Submitted by: OlivierW <olivierw1+bugzilla-freebsd@hotmail.com> Changes: head/net-mgmt/smokeping/Makefile head/net-mgmt/smokeping/files/patch-lib_Smokeping.pm
Committed, thanks.