Bug 253329 - www/bluefish: needs update, 2.2.12 builds fine
Summary: www/bluefish: needs update, 2.2.12 builds fine
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ben Woods
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-02-07 21:54 UTC by tigersharke
Modified: 2021-02-07 23:36 UTC (History)
0 users

See Also:
woodsb02: maintainer-feedback+


Attachments
output of pkg info for www/bluefish (1.55 KB, text/plain)
2021-02-07 21:54 UTC, tigersharke
no flags Details
Patch to update www/bluefish to 2.2.12 (1.48 KB, patch)
2021-02-07 23:33 UTC, Ben Woods
woodsb02: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tigersharke 2021-02-07 21:54:21 UTC
Created attachment 222248 [details]
output of pkg info for www/bluefish

I changed the version number in the Makefile, made new distinfo and pkg-plist.  The generated pkg-plist differs slightly, line three needed adjustment and missing four lines (below), unsure if those need to be added back. Tested and then built with poudriere.

%%DATADIR%%/lipsum/__init__.py 
%%DATADIR%%/lipsum/data/dictionary.txt 
%%DATADIR%%/lipsum/data/lipsum.xml 
%%DATADIR%%/lipsum/data/sample.txt 

Unsure if makefile should be modified to automate the plist adjustment to prepend %%GTK3%% to the line lib/bluefish/charmap.so

Attached output of `pkg info bluefish` after successful build.
Comment 1 Ben Woods freebsd_committer freebsd_triage 2021-02-07 23:33:03 UTC
Hi Tiger Shark!

Thanks for the bug report, and details on how to resolve.

A couple of pointers if I may, to help with the next one :)

Making the new distinfo - if you didn't already know, that can be done automatically by running "make makesum" after updating the version in Makefile.

As for submitting the required changes, the best way is to submit a diff/patch. I have the ports tree checked out using subversion, so I do this by running "svn diff".

The below shows the sequence of the commands I use:
$ cd /usr/ports/www/bluefish
$ vi Makefile
$ make makesum
$ vi pkg-plist
# poudriere testport -j 12amd64 -i www/bluefish
$ cd /usr/ports
$ svn diff www/bluefish

This generates a patch like the one attached.
Comment 2 Ben Woods freebsd_committer freebsd_triage 2021-02-07 23:33:31 UTC
Created attachment 222250 [details]
Patch to update www/bluefish to 2.2.12
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-02-07 23:35:54 UTC
A commit references this bug:

Author: woodsb02
Date: Sun Feb  7 23:35:04 UTC 2021
New revision: 564665
URL: https://svnweb.freebsd.org/changeset/ports/564665

Log:
  www/bluefish: Update to 2.2.12

  Also remove obsolete pkg-message from 2013, warning about
  the update to tiny4

  PR:		253329
  Reported by:	tigersharke@gmail.com

Changes:
  head/www/bluefish/Makefile
  head/www/bluefish/distinfo
  head/www/bluefish/pkg-message
  head/www/bluefish/pkg-plist
Comment 4 Ben Woods freebsd_committer freebsd_triage 2021-02-07 23:36:26 UTC
Committed - thanks again for the bug report!