Bug 253349 - devel/ocaml-opam: Update to 2.0.8
Summary: devel/ocaml-opam: Update to 2.0.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL: https://github.com/ocaml/opam/blob/2....
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-02-08 15:41 UTC by Hannes Mehnert
Modified: 2021-02-09 05:58 UTC (History)
2 users (show)

See Also:

Attachments
output of diff -ur ocaml-opam.old ocaml-opam (1018 bytes, patch)
2021-02-08 15:41 UTC, Hannes Mehnert 		hannes: maintainer-approval+
Details | Diff
patch with STRIP_CMD and ordered Makefile vars (1.84 KB, patch)
2021-02-08 19:48 UTC, Rainer Hurling 		hannes: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hannes Mehnert 2021-02-08 15:41:57 UTC 
Created attachment 222269 [details]
output of diff -ur ocaml-opam.old ocaml-opam

Hi (maintainer here),

ocaml-opam 2.0.8 was just released today, please find attached the update to the port (as unified diff).

Thanks a lot,

Hannes
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2021-02-08 17:17:21 UTC 
[tags] in issue Titles are deprecated ;)
Comment 2 Automation User 2021-02-08 19:28:01 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/253127972
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2021-02-08 19:48:15 UTC 
Created attachment 222276 [details]
patch with STRIP_CMD and ordered Makefile vars

Hi Hannes,

Thanks for the patch!

I added STRIP_CMD for bin/ocaml-installer, as suggested from 'make DEVELOPER=yes'.

While here, I also ordered Makefile vars, as suggested by portclippy ;)

If you agree, I would commit with these changes.
Comment 4 Hannes Mehnert 2021-02-08 20:05:34 UTC 
Comment on attachment 222276 [details]
patch with STRIP_CMD and ordered Makefile vars

Thanks, I hereby approve your additional changes.
Comment 5 Rainer Hurling freebsd_committer freebsd_triage 2021-02-08 20:51:52 UTC 
(In reply to Rainer Hurling from comment #3)
Thanks for the quick feedback :D


One more suggestion:

If you want to show OPTIONS in the sorted order 'RSYNC GIT HG DARCS' as in your OPTIONS_DEFINE line, one have to add NO_OPTIONS_SORT=yes.

Should I do this additionally?  [no more approval needed ;) ]
Comment 6 Hannes Mehnert 2021-02-08 21:50:52 UTC 
(In reply to Rainer Hurling from comment #5)

Sure, thanks for your suggestions and review. That'd be a great improvement to show the option in the above mentioned order.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2021-02-09 01:44:28 UTC 
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-02-09 05:52:37 UTC 
A commit references this bug:

Author: rhurlin
Date: Tue Feb  9 05:52:20 UTC 2021
New revision: 564763
URL: https://svnweb.freebsd.org/changeset/ports/564763

Log:
  devel/ocaml-opam: Update to 2.0.8

  Changlog: https://github.com/ocaml/opam/blob/2.0.8/CHANGES

  PR:		253349
  Submitted by:	hannes@mehnert.org (maintainer)
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D28544

Changes:
  head/devel/ocaml-opam/Makefile
  head/devel/ocaml-opam/distinfo
Comment 9 Rainer Hurling freebsd_committer freebsd_triage 2021-02-09 05:58:58 UTC 
Committed, thanks :)