Bug 253485 - security/tailscale: Version string is not compiled in
Summary: security/tailscale: Version string is not compiled in
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-13 16:17 UTC by James O'Gorman
Modified: 2021-02-18 16:32 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mikael)

Attachments
GO_BUILDFLAGS patch (430 bytes, patch)
2021-02-13 16:17 UTC, James O'Gorman 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James O'Gorman 2021-02-13 16:17:18 UTC 
Created attachment 222411 [details]
GO_BUILDFLAGS patch

The Tailscale build instructions ask that distributions use https://github.com/tailscale/tailscale/blob/main/build_dist.sh or equivalent commands to ensure that the version of the binary is compiled in; otherwise it uses a date-based version based on the build date.

The current package version's (1.4.2) binary outputs:

% tailscale version
date.20210104
  go version: go1.15.8

An official binary (e.g. the MacOS version) outputs the correct version:

1.4.4
  tailscale commit: 64a9656c01754b6652994cb3a8ef59bce1246cfc
  other commit: 21107eaa91253420fce6d0a4b8e9c0369e3480f8
  go version: go1.15.7-ts02f50cd

Attached is a patch to compile in the PORTVERSION in the version package in the same manner as build_dist.sh, without the git hash (as it's neither available nor required).
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-02-18 16:32:28 UTC 
A commit references this bug:

Author: mikael
Date: Thu Feb 18 16:32:09 UTC 2021
New revision: 565948
URL: https://svnweb.freebsd.org/changeset/ports/565948

Log:
  security/tailscale: set version

  PR:		253485
  Submitted by:	James O'Gorman

Changes:
  head/security/tailscale/Makefile
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2021-02-18 16:32:53 UTC 
thanks!