Bug 253605 - net/tayga writes "something" to syslog
Summary: net/tayga writes "something" to syslog
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-17 22:53 UTC by Maurice Walker
Modified: 2024-10-25 16:57 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (melifaro)


Attachments
remove debug message (5.25 KB, patch)
2023-04-18 06:30 UTC, Franco Fichtner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maurice Walker 2021-02-17 22:53:25 UTC
On my system (OPNsense 21.1 / FreeBSD 12.1), Tayga writes "Wrote somethinh" [sic] to the syslog 50+ times per day. While there are no apparent issues, I'd like to understand what causes these warnings.

I found the relevant line of code in the FreeBSD port (while finding nothing in the original Tayga code), so this seems to be FreeBSD-specific:

https://svnweb.freebsd.org/ports/head/net/tayga/files/patch-freebsd?view=markup#l57

I fail to understand what triggers this warning even when looking at the code. It might be desirable to replace it with something more meaningful.

Thank you.
Comment 1 Alexander V. Chernikov freebsd_committer freebsd_triage 2021-02-17 23:14:07 UTC
Hi Marius,

From what I see, it's the debug message accidentally left in "host_send_icmp6()".
I guess it's safe to remove, though I'm not sure if I have cycles to do so.

Btw, is there any particular reason you're not using ipfw nat64 functionality?
Comment 2 Maurice Walker 2021-02-17 23:38:24 UTC
Thanks Alexander,

Good to know that this can be safely ignored.

OPNsense developers have discussed supporting ipfw NAT64. But since OPNsense is mostly pf-based, this unfortunately won't happen anytime soon. A Tayga plugin was released as an interims solution.
Comment 3 Franco Fichtner 2023-04-18 06:29:37 UTC
I wrote a a patch for it: https://github.com/opnsense/ports/commit/df4d23f1314bd
Comment 4 Franco Fichtner 2023-04-18 06:30:38 UTC
Created attachment 241553 [details]
remove debug message
Comment 5 Alexander V. Chernikov freebsd_committer freebsd_triage 2023-04-18 14:38:43 UTC
Thank you!
Unfortunately, I'm not able to maintain this port anymore. I've reset the PR assignment back to 'ports@'. Please feel free to take the port ownership if you're interested.
Comment 6 Franco Fichtner 2023-04-19 07:01:48 UTC
I'm ok with maintaining it, but since I'm not a committer I need help getting this committed. ;)


Cheers,
Franco
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-24 17:02:24 UTC
(In reply to Franco Fichtner from comment #6)
Franco, if the maintaining is still okay, I'll commit it.
Comment 8 Franco Fichtner 2024-10-24 18:20:18 UTC
Hi,

Yes please. That would be great.


Cheers,
Franco
Comment 9 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-25 16:56:58 UTC
Committed, thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-10-25 16:57:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8822c36b1cff3af829ab7f67b8e63837eab192ec

commit 8822c36b1cff3af829ab7f67b8e63837eab192ec
Author:     Franco Fichtner <franco@opnsense.org>
AuthorDate: 2024-10-25 16:52:48 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-10-25 16:55:55 +0000

    net/tayga: Remove debug message

    Add LICENSE_FILE.
    Submitter takes maintainership.
    Switch to DISTVERSION.

    PR:             253605
    Approved by:    melifaro (ex-maintainer)

 net/tayga/Makefile            |  8 +++---
 net/tayga/files/patch-freebsd | 58 +++++++++++++++++--------------------------
 2 files changed, 27 insertions(+), 39 deletions(-)