Bug 253978 - net/coturn: rc script fixes
Summary: net/coturn: rc script fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-03 11:01 UTC by Chris Rees
Modified: 2021-03-03 19:28 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Fixes (3.64 KB, patch)
2021-03-03 11:01 UTC, Chris Rees 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees freebsd_committer freebsd_triage 2021-03-03 11:01:08 UTC 
Created attachment 222938 [details]
Fixes

Currently the pidfile doesn't match the rc script, fetch from config file.

The user should not be able to override the -o flag as this will hang startup, so move to command_args.

${name}_flags is included in command_args by rc.subr anyway, so remove that too.

Add description.

Pet rclint.

Integrate into ports Makefile correctly.
Comment 1 Chris Rees freebsd_committer freebsd_triage 2021-03-03 11:02:00 UTC 
Oops, really sorry, wrong assignee as I put the wrong port origin...
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2021-03-03 19:27:54 UTC 
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-03-03 19:28:39 UTC 
A commit references this bug:

Author: yuri
Date: Wed Mar  3 19:27:41 UTC 2021
New revision: 567256
URL: https://svnweb.freebsd.org/changeset/ports/567256

Log:
  net/coturn: rc script fixes

  * Fetch pidfile from config file
  * Integrate into ports Makefile correctly
  * Pet rclint

  PR:		253978
  Submitted by:	crees

Changes:
  head/net/coturn/Makefile
  head/net/coturn/files/turnserver-service.in
  head/net/coturn/files/turnserver.in
  head/net/coturn/pkg-plist