Bug 254020 - net/tcptestsuite: update to latest version
Summary: net/tcptestsuite: update to latest version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-05 00:47 UTC by Michael Tuexen
Modified: 2021-03-05 02:02 UTC (History)
1 user (show)

See Also:

Attachments
Patch for updating the Makefile (500 bytes, patch)
2021-03-05 00:47 UTC, Michael Tuexen 		no flags Details | Diff
Patch for updating the Makefile (1.12 KB, patch)
2021-03-05 01:13 UTC, Michael Tuexen 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Tuexen freebsd_committer freebsd_triage 2021-03-05 00:47:11 UTC 
Created attachment 222986 [details]
Patch for updating the Makefile

Please update to the latest version of the tests, I just committed to the GitHub repo.
Comment 1 Neel Chauhan freebsd_committer freebsd_triage 2021-03-05 00:59:54 UTC 
You probably should run `make makesum` on the net/tcptestsuite before committing this as Ports updates usually need an updated checksum, even if it's via GitHub.
Comment 2 Michael Tuexen freebsd_committer freebsd_triage 2021-03-05 01:13:44 UTC 
Created attachment 222987 [details]
Patch for updating the Makefile
Comment 3 Michael Tuexen freebsd_committer freebsd_triage 2021-03-05 01:15:56 UTC 
(In reply to Neel Chauhan from comment #1)
This is my first patch for a port. Thanks for the hint. I updated the patch.
Comment 4 Neel Chauhan freebsd_committer freebsd_triage 2021-03-05 01:22:19 UTC 
LGTM.

src committers should be able to commit to ports if a ports committer (like me) gives approval. Be sure to mention something like:

Approved by: nc

In the commit message.

An example: While I'm not as big into TCP hacking anymore, I, a ports committer, was able to commit some TCP/IP patches since a src committer approved.

The same way, you, a src committer, can commit to ports with approval from someone like me.

If you'd rather have me commit this, let me know and I can happily do this.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-03-05 01:36:44 UTC 
A commit references this bug:

Author: tuexen
Date: Fri Mar  5 01:36:09 UTC 2021
New revision: 567354
URL: https://svnweb.freebsd.org/changeset/ports/567354

Log:
  Update the test suite to the latest version on Github.

  PR:		254020
  Approved by:	nc

Changes:
  head/net/tcptestsuite/Makefile
  head/net/tcptestsuite/distinfo
Comment 6 Michael Tuexen freebsd_committer freebsd_triage 2021-03-05 01:37:52 UTC 
(In reply to Neel Chauhan from comment #4)
Thanks a lot, it worked. Thank you very much for the prompt support!
Comment 7 Neel Chauhan freebsd_committer freebsd_triage 2021-03-05 01:50:29 UTC 
A tip for next time: While I know you're more of a src person and (probably) won't be in Ports too often, when committing to Ports, you should have a message like:

net/tcptestsuite: Update to 0.0.4

Otherwise, good to hear it worked!
Comment 8 Michael Tuexen freebsd_committer freebsd_triage 2021-03-05 02:02:57 UTC 
(In reply to Neel Chauhan from comment #7)
Thanks again for the hint. Will do that next time.