Created attachment 222995 [details] patch On the mailing lists user Antonio Olivares <olivares14031@gmail.com> reported on current@ that xfig installs an incorrect desktop entry, with /usr/bin/xfig binary path hardcoded. Attached patch fixes this replacing the hardcoded path with one generated from PREFIX, pointing to the actually installed binary location. While here I also converted the port to USES localbase and silenced some portlint warnings about order of statements. Can you approve these changes?
As maintainer, I am fine with this patch being committed. One question though: is the full path in the Exec line even needed? I noticed emacs.desktop just has Exec=emacs %F Lastly, can someone please look at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252092 Its the latest version of xfig (3 months ago).
A commit references this bug: Author: madpilot Date: Sat Mar 6 11:34:28 UTC 2021 New revision: 567478 URL: https://svnweb.freebsd.org/changeset/ports/567478 Log: - Fix .desktop entry, remove wrong path from Exec line - Convert port to USES=localbase - SSilence portlint warnings about variables order PR: 254031 Approved by: mjl@luckie.org.nz (maintainer) MFH: 2021Q1 Changes: head/graphics/xfig/Makefile
A commit references this bug: Author: madpilot Date: Sat Mar 6 11:35:50 UTC 2021 New revision: 567479 URL: https://svnweb.freebsd.org/changeset/ports/567479 Log: MFH: r567478 - Fix .desktop entry, remove wrong path from Exec line - Convert port to USES=localbase - Silence portlint warnings about variables order PR: 254031 Approved by: mjl@luckie.org.nz (maintainer) Changes: _U branches/2021Q1/ branches/2021Q1/graphics/xfig/Makefile
Committed this patch and also merged it to quarterly. Your other issue is assigned to the committed who is also maintaining the other port involved. I also see him in CC to this bug report, so he is reading these messages. If he can't handle it he can return it to the pool to signal other committers it can be taken.