Bug 254131 - www/qutebrowser: Add run time dependency on www/py-adblock for AMD64
Summary: www/qutebrowser: Add run time dependency on www/py-adblock for AMD64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-08 11:50 UTC by Adam Jimerson
Modified: 2021-03-13 01:37 UTC (History)
3 users (show)

See Also:
fernape: maintainer-feedback? (novel)

Attachments
Patch to add new RUN_DEPENDS (778 bytes, patch)
2021-03-08 11:50 UTC, Adam Jimerson 		no flags Details | Diff
Patch v2 to add py-adblock as RUN_DEPENS (1.42 KB, patch)
2021-03-12 11:34 UTC, Adam Jimerson 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Jimerson 2021-03-08 11:50:17 UTC 
Created attachment 223092 [details]
Patch to add new RUN_DEPENDS

This patch adds www/py-adblock as a runtime dependency if Qutebrowser is being built for AMD64.
Comment 1 Benjamin Takacs 2021-03-08 12:11:22 UTC 
As it only adds an optional feature and ports/packages don't support suggested packages, this should be an OPTION, like youtube-dl is for mpv
Comment 2 Roman Bogorodskiy freebsd_committer freebsd_triage 2021-03-10 09:36:28 UTC 
(In reply to nimaje+fbz from comment #1)

Agreed, it won't hurt to make it an OPTION (enabled by default though).
Comment 3 Adam Jimerson 2021-03-10 11:49:44 UTC 
I'm okay with making this optional and enabled by defualt for AMD64 builds. It might take a few days for poudirere's testport to run on my build box.
Comment 4 Adam Jimerson 2021-03-12 11:34:02 UTC 
Created attachment 223205 [details]
Patch v2 to add py-adblock as RUN_DEPENS

This patch adds py-adblock as an OPTION for AMD64 builds.

Also after talking with the maintainer this patch makes a few small changes suggested by portclippy.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-03-13 01:33:35 UTC 
A commit references this bug:

Author: novel
Date: Sat Mar 13 01:33:25 UTC 2021
New revision: 568225
URL: https://svnweb.freebsd.org/changeset/ports/568225

Log:
  www/qutebrowser: add adblock support

   - Introduce ADBLOCK option that adds adblock support via www/py-adblock.
     As py-adblock is currently available only for amd64, limit the option
     to amd64 too,
   - Reorder some Makefile variables based on portclippy suggestions.

  PR:		254131
  Submitted by:	Adam Jimerson

Changes:
  head/www/qutebrowser/Makefile
Comment 6 Roman Bogorodskiy freebsd_committer freebsd_triage 2021-03-13 01:37:53 UTC 
Committed, thanks!