Bug 254150 - net-im/tg_owt: mark port broken on 11 with base OpenSSL
Summary: net-im/tg_owt: mark port broken on 11 with base OpenSSL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lewis Cook
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-09 04:04 UTC by Henry Hu
Modified: 2021-03-10 14:11 UTC (History)
1 user (show)

See Also:

Attachments
patch to mark it as broken (777 bytes, patch)
2021-03-09 04:04 UTC, Henry Hu 		henry.hu.sh: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2021-03-09 04:04:48 UTC 
Created attachment 223107 [details]
patch to mark it as broken

The OpenSSL in base is too old for FreeBSD 11. Mark the port as broken.
I've tried DEFAULT_VERSIONS+= ssl=openssl, and this port builds fine, so we don't need to mark it as broken in that case.
Comment 1 Henry Hu 2021-03-09 04:06:57 UTC 
Poudriere log on 11.4-p8/i386 with openssl from ports: https://raw.githubusercontent.com/HenryHu/ports/master/.logs/11.4-i386/tg_owt-0.0.20210207.log
Comment 2 Lewis Cook freebsd_committer freebsd_triage 2021-03-09 14:44:34 UTC 
Moin moin,

Everything looks good. Only one minor nit as suggested by portclippy[1]:

$ portclippy Makefile
# PORTNAME block
PORTNAME
PORTVERSION
CATEGORIES

# Maintainer block
MAINTAINER
COMMENT

# License block
LICENSE
LICENSE_FILE

# Dependencies
BUILD_DEPENDS
LIB_DEPENDS

# USES block
USES
USE_GITHUB
GH_ACCOUNT
GH_PROJECT
GH_TAGNAME
GH_TUPLE

# USES=cmake related variables
+CMAKE_OFF

# CFLAGS/CXXFLAGS/LDFLAGS block
CXXFLAGS

-CMAKE_OFF

Are you happy with me including this in the commit?

[1] https://www.freshports.org/ports-mgmt/portfmt
Comment 3 Henry Hu 2021-03-10 01:36:54 UTC 
(In reply to Lewis Cook from comment #2)
Sure, this looks fine. Maybe I should take a look at this tool.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-03-10 14:11:11 UTC 
A commit references this bug:

Author: lcook
Date: Wed Mar 10 14:10:24 UTC 2021
New revision: 568003
URL: https://svnweb.freebsd.org/changeset/ports/568003

Log:
  net-im/tg_owt: Mark port BROKEN on 11 with base OpenSSL

  While here, pet both portclippy and portfmt.

  PR: 			254150
  Submitted by:		Henry Hu <henry.hu.sh@gmail.com> (maintainer)
  Approved by:		fernape (mentor)
  Differential Revision:	https://reviews.freebsd.org/D29184

Changes:
  head/net-im/tg_owt/Makefile
Comment 5 Lewis Cook freebsd_committer freebsd_triage 2021-03-10 14:11:32 UTC 
Committed, thanks!