A portupgrade of net-mgmt/irrtoolset from 'irrtoolset-5.0.1' to 'irrtoolset-5.1.3' on 12.2-STABLE fails with multiple errors. First set of errors: (1:123) rz2:/usr/ports/net-mgmt/irrtoolset# portupgrade irrtoolset [Reading data from pkg(8) ... - 159 packages found - done] ---> Upgrading 'irrtoolset-5.0.1' to 'irrtoolset-5.1.3' (net-mgmt/irrtoolset) ---> Building '/usr/ports/net-mgmt/irrtoolset' ===> Cleaning for irrtoolset-5.1.3 ===> License not correctly defined: for unknown licenses, defining LICENSE_PERMS_RIPE_NCC is mandatory (otherwise use a known LICENSE) make: exec(exit) failed (No such file or directory) *** Error code 1 Stop. make: stopped in /usr/ports/net-mgmt/irrtoolset ** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade20210310-61662-ra4bwb env UPGRADE_TOOL=portupgrade UPGRADE_PORT=irrtoolset-5.0.1 UPGRADE_PORT_VER=5.0.1 make ** Fix the problem and try again. ** Listing the failed packages (-:ignored / *:skipped / !:failed) ! net-mgmt/irrtoolset (irrtoolset-5.0.1) (unknown build error) If I comment out the 3 LICENSE* lines in the port Makefile, I get: (0:125) rz2:/usr/ports/net-mgmt/irrtoolset# portupgrade irrtoolset [Reading data from pkg(8) ... - 159 packages found - done] ---> Upgrading 'irrtoolset-5.0.1' to 'irrtoolset-5.1.3' (net-mgmt/irrtoolset) ---> Building '/usr/ports/net-mgmt/irrtoolset' ===> Cleaning for irrtoolset-5.1.3 ===> irrtoolset-5.1.3 depends on file: /usr/local/sbin/pkg - found ===> Fetching all distfiles required by irrtoolset-5.1.3 for building ===> Extracting for irrtoolset-5.1.3 => SHA256 Checksum OK for irrtoolset-irrtoolset-release-5.1.3_GH0.tar.gz. ===> Patching for irrtoolset-5.1.3 ===> Applying FreeBSD patches for irrtoolset-5.1.3 from /usr/ports/net-mgmt/irrtoolset/files 2 out of 3 hunks failed--saving rejects to src/rpsl/rpsl.y.rej ===> FAILED Applying FreeBSD patch-src-rpsl-rpsl.y ===> Cleanly applied FreeBSD patch(es) patch-src-rpsl-rpsl.l ===> FAILED to apply cleanly FreeBSD patch(es) patch-src-rpsl-rpsl.y *** Error code 1 Stop. make: stopped in /usr/ports/net-mgmt/irrtoolset ** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade20210310-62047-kn3znv env UPGRADE_TOOL=portupgrade UPGRADE_PORT=irrtoolset-5.0.1 UPGRADE_PORT_VER=5.0.1 make ** Fix the problem and try again. ** Listing the failed packages (-:ignored / *:skipped / !:failed) ! net-mgmt/irrtoolset (irrtoolset-5.0.1) (patch error) So I think there's something badly broken with this new version of the port. NOTE: Direct email to the committer bounces with an SPF error when freebsd.org forwards the email to the committer. Reported to postmaster@ for further study.
The deletion of all patches is missing from the svn diff. I'm pretty sure that I need to add an option to the diff. Sorry for the oversight. I have license checks disabled on my system. I'll try to figure this out, as well. I suspect it will be obvious once I look. You can get it to build with "rm -r /usr/ports/net-mgmt/irrtoolset/files" Sorry.
Created attachment 223179 [details] Correct for deleted patch files and fix licenses Add license details for RIPE_NCC and deal with removed patch files
(In reply to rkoberman from comment #1) Yes, after deleting the patch files it builds properly. Thanks for the quick fix! I just left the LICENSE* stuff commented out in my Makefile - I'll pick up that fix when your fix gets pushed to the ports repository.
The patch has a mix of things now. It tries to update to 5.1.3 and do other things (deleting files/ and updating license info). Since the port is already in 5.1.3, it fails to apply. I will remove the files/ directory and apply the LICENSE changes.
Committed, Thanks!
A commit references this bug: Author: fernape Date: Fri Mar 12 11:14:10 UTC 2021 New revision: 568167 URL: https://svnweb.freebsd.org/changeset/ports/568167 Log: net-mgmt/irrtoolset: Unbreak in 12.2-STABLE And possibly in other places. Remove files/ missed in previous update and fix LICENSE permissions. PR: 254213 Submitted by: rkoberman@gmail.com (maintainer) Reported by: terry-freebsd@glaver.org Changes: head/net-mgmt/irrtoolset/Makefile head/net-mgmt/irrtoolset/files/