Bug 254340 - graphics/freeimage: add pkgconf file
Summary: graphics/freeimage: add pkgconf file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-16 17:29 UTC by Freddy DISSAUX
Modified: 2021-03-30 06:33 UTC (History)
2 users (show)

See Also:

Attachments
pkgconf file (215 bytes, text/plain)
2021-03-16 17:29 UTC, Freddy DISSAUX 		no flags Details
patch to install pkgconf file (1.14 KB, patch)
2021-03-16 17:31 UTC, Freddy DISSAUX 		no flags Details | Diff
refreshed patch to install pkgconf file (3.41 KB, patch)
2021-03-17 08:23 UTC, Nuno Teixeira 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Freddy DISSAUX 2021-03-16 17:29:10 UTC 
Created attachment 223328 [details]
pkgconf file

attach a pkgconf file
attach a patch to install pkgconf file
Comment 1 Freddy DISSAUX 2021-03-16 17:31:04 UTC 
Created attachment 223329 [details]
patch to install pkgconf file

bump portrevision
Comment 2 Freddy DISSAUX 2021-03-16 17:33:35 UTC 
$ pkgconf --modversion freeimage
3.18.0
$ pkgconf --libs freeimage
-L/usr/local/lib -lfreeimage
$ pkgconf --cflags freeimage
-I/usr/local/include
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2021-03-17 08:23:02 UTC 
Created attachment 223353 [details]
refreshed patch to install pkgconf file

Hello Freddy,

I refreshed your patch so it can be applied to lastest svn commit 568636.

I've tested pkgconf support and graphics/imv 4.2.0 now builds ok.

You can follow my review at:
https://reviews.freebsd.org/D29311

Cheers
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-03-30 06:27:35 UTC 
A commit references this bug:

Author: eduardo
Date: Tue Mar 30 06:27:22 UTC 2021
New revision: 569542
URL: https://svnweb.freebsd.org/changeset/ports/569542

Log:
  graphics/freeimage: Add pkgconf support

  While here:
    - Take MAINTAINER'ship
    - reorder Makefile (portclippy)

  PR:		254340
  Submitted by:	Freddy DISSAUX <dsx@bsdsx.fr>
  Approved by:	dbaio (mentor)
  Differential Revision:	https://reviews.freebsd.org/D29311

Changes:
  head/graphics/freeimage/Makefile
  head/graphics/freeimage/files/freeimage.pc.in
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2021-03-30 06:32:27 UTC 
Committed thanks!