Bug 254363 - net/frr7: empty rcvar in startup script
Summary: net/frr7: empty rcvar in startup script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-17 14:18 UTC by MB
Modified: 2021-03-24 21:03 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (olivier)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description MB 2021-03-17 14:18:48 UTC 
Port: net/frr7

The startup script sets an empty $rcvar:

  rcvar=$name_enable

Maybe I am wrong, but I think that "name" should be placed between curly brackets:

  rcvar=${name}_enable

This would prevent the following warnings:

# /etc/rc.d/routing start
/etc/rc.d/routing: WARNING: $ is not set properly - see rc.conf(5).
[...]

Thanks in advance for your feedback Olivier !

Best regards,

Mattieu
Comment 1 Olivier Cochard freebsd_committer freebsd_triage 2021-03-24 20:38:29 UTC 
I don't reach to reproduce your WARNING message, but there is indeed a wrongly set rcvar.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-03-24 20:52:16 UTC 
A commit references this bug:

Author: olivier
Date: Wed Mar 24 20:52:14 UTC 2021
New revision: 569159
URL: https://svnweb.freebsd.org/changeset/ports/569159

Log:
  Fix rcvar declaration in rc script

  PR:		254363
  Reported by:	fault.seg@laposte.net

Changes:
  head/net/frr7/Makefile
  head/net/frr7/files/frr.in
Comment 3 Olivier Cochard freebsd_committer freebsd_triage 2021-03-24 20:53:06 UTC 
Thanks for your report
Comment 4 MB 2021-03-24 21:03:05 UTC 
Thank you for your fix !