Bug 254444 - deskutils/fbreader: add QT5 flavor
Summary: deskutils/fbreader: add QT5 flavor
Status: Closed DUPLICATE of bug 283455
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-20 21:15 UTC by Olga Smirnova
Modified: 2025-02-18 14:37 UTC (History)
4 users (show)

See Also:

Attachments
shar file (24.45 KB, text/plain)
2021-03-20 21:15 UTC, Olga Smirnova 		no flags Details
add qt5 flavor (17.24 KB, patch)
2024-11-12 10:54 UTC, mew14930xvi 		no flags Details | Diff
add qt5 flavor (17.26 KB, patch)
2024-11-14 05:38 UTC, mew14930xvi 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olga Smirnova 2021-03-20 21:15:06 UTC 
Created attachment 223457 [details]
shar file

This patch adds a new default QT5 flavor.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2021-03-20 21:15:06 UTC 
Maintainer informed via mail
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2024-11-02 20:22:40 UTC 
The upstream repository is archived about 3 years ago (about half year later than this PR). Are you still using this port? The latest Qt 5.15 released more than 4 years ago, and its support is near at the end.
Comment 3 BorichL 2024-11-07 12:19:00 UTC 
I'm still using this port. Current port version don't depend on qt5 anymore.
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-11-11 16:07:38 UTC 
(In reply to BorichL from comment #3)
Is it worth working on a discontinued project to add support for a feature (Qt5) whose support is gradually expiring?
Comment 5 mew14930xvi 2024-11-12 10:54:13 UTC 
Created attachment 255117 [details]
add qt5 flavor

Slight changes were made because the build was failing.
I don't mind not supporting qt.
But I still use it.
Comment 6 mew14930xvi 2024-11-14 05:38:54 UTC 
Created attachment 255160 [details]
add qt5 flavor

Minor fix.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2025-02-16 15:40:46 UTC 
Obsoleted by bug #283455.
Thank you for bringing up this patch, which mew14930xvi ported to QT6.
You will be credited.

*** This bug has been marked as a duplicate of bug 283455 ***
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-02-18 14:29:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb351bf34abe079cde3da7cbe607c34c217c0249

commit fb351bf34abe079cde3da7cbe607c34c217c0249
Author:     mew14930xvi <mew14930xvi@inbox.lv>
AuthorDate: 2024-12-20 23:18:12 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-02-18 14:16:21 +0000

    deskutils/fbreader: take maintainership and flavorize

     - add QT6 flavour

    PR:             283455, 254444
    Approved by:    johannes@perceivon.net (maintainer timeout)
    Reported by:    Olga Smirnova <mistresssilvara@hotmail.com>
    Co-authored-by: Olga Smirnova <mistresssilvara@hotmail.com>

 deskutils/fbreader/Makefile                        |  43 ++-
 ...patch-fbreader_src_database_booksdb_BooksDB.cpp |   2 +-
 .../fbreader/files/patch-makefiles_arch_desktop.mk |  19 +-
 deskutils/fbreader/files/patch-qt6support (new)    | 351 +++++++++++++++++++++
 ...ary_core_src_unix_curl_ZLCurlNetworkManager.cpp |   2 +-
 ...tch-zlibrary_core_src_unix_time_ZLUnixTime.cpp} |   0
 ...tch-zlibrary_text_src_area_ZLTextAreaStyle.cpp} |   0
 ...-zlibrary_ui_src_qt4_dialogs_ZLQtUtil.cpp (new) |  11 +
 ...y_ui_src_qt4_filesystem_ZLQtFSManager.cpp (new) |  11 +
 ...rary_ui_src_qt4_view_ZLQtPaintContext.cpp (new) |  17 +
 deskutils/fbreader/pkg-plist                       |   4 +-
 11 files changed, 442 insertions(+), 18 deletions(-)
Comment 9 Robert Clausecker freebsd_committer freebsd_triage 2025-02-18 14:37:56 UTC 
Thank you for your contribution.