Bug 254477 - devel/gammaray: fix amd64 ABI detection, build
Summary: devel/gammaray: fix amd64 ABI detection, build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL: https://github.com/KDAB/GammaRay/pull...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-03-22 12:48 UTC by Val Packett
Modified: 2021-03-23 23:27 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)


Attachments
gammaray.patch (3.23 KB, patch)
2021-03-22 12:48 UTC, Val Packett
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2021-03-22 12:48:59 UTC
Created attachment 223498 [details]
gammaray.patch

This fixes the ABI detection (gammaray was unusable on amd64, because the files would be built as 'amd64' but runtime would look for 'x86_64') and build (-liberty not found — seems it's a mistake, supposed to be a dependency when using static libbfd, but it was detecting dynamic). These are submitted upstream as https://github.com/KDAB/GammaRay/pull/629

Plus, exclude the qt5 WaylandCompositor module as it's producing CMake macro errors. I'm not sure why though, maybe that's my problem somehow.

// I guess the bfd error only happens when building with bfd installed, maybe an explicit dependency on elftoolchain/libbfd or disabling of these features could be good
Comment 1 Steve Wills freebsd_committer freebsd_triage 2021-03-22 13:28:58 UTC
(In reply to Greg V from comment #0)
Thanks, I was just passing the ABI on the command line. I'll take a look and get it committed.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-03-23 23:24:39 UTC
A commit references this bug:

Author: swills
Date: Tue Mar 23 23:23:51 UTC 2021
New revision: 569071
URL: https://svnweb.freebsd.org/changeset/ports/569071

Log:
  devel/gammaray: fix amd64 ABI detection, build

  PR:		254477
  Submitted by:	Greg V <greg@unrelenting.technology>
  --This line, and those below, will be ignored--
  > Description of fields to fill in above:                     76 columns --|
  > PR:                       If and which Problem Report is related.
  > Submitted by:             If someone else sent in the change.
  > Reported by:              If someone else reported the issue.
  > Reviewed by:              If someone else reviewed your modification.
  > Approved by:              If you needed approval for this commit.
  > Obtained from:            If the change is from a third party.
  > MFC after:                N [day[s]|week[s]|month[s]].  Request a reminder email.
  > MFH:                      Ports tree branch name.  Request approval for merge.
  > Relnotes:                 Set to 'yes' for mention in release notes.
  > Security:                 Vulnerability reference (one per line) or description.
  > Sponsored by:             If the change was sponsored by an organization.
  > Differential Revision:    https://reviews.freebsd.org/D### (*full* phabric URL needed).
  > Empty fields above will be automatically removed.

Changes:
  head/devel/gammaray/Makefile
  head/devel/gammaray/files/
  head/devel/gammaray/files/patch-3rdparty_backward-cpp_BackwardMacros.cmake
  head/devel/gammaray/files/patch-CMakeLists.txt
  head/devel/gammaray/files/patch-cmake_GammaRayProbeABI.cmake
Comment 3 Steve Wills freebsd_committer freebsd_triage 2021-03-23 23:27:08 UTC
Committed, thanks!