Bug 254654 - shells/fish: Fix build with OPTIONS_SET+=DEBUG
Summary: shells/fish: Fix build with OPTIONS_SET+=DEBUG
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alan Somers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-30 05:41 UTC by Kevin Zheng
Modified: 2021-06-03 21:44 UTC (History)
0 users

See Also:
asomers: maintainer-feedback+

Attachments
Patch (1.12 KB, patch)
2021-03-30 05:41 UTC, Kevin Zheng 		asomers: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2021-03-30 05:41:15 UTC 
Created attachment 223703 [details]
Patch

When DEBUG is set in make.conf, CMake builds in debug mode. However,
this does not cause the fish-releasenotes(1) man page to be installed as
fish-debugnotes(1). Correct the entry in pkg-plist to fix the build in
this case.
Comment 1 Alan Somers freebsd_committer freebsd_triage 2021-06-02 22:43:40 UTC 
LGTM!  Thanks for the fix.  Sorry I didn't notice it at first.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-06-03 21:40:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=77e8418d5acdbf09119536ca1586b28cdbdecc84

commit 77e8418d5acdbf09119536ca1586b28cdbdecc84
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2021-06-03 21:34:22 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2021-06-03 21:39:47 +0000

    shells/fish: fix the build with the DEBUG option

    Approved by:    dbaio (ports)
    Submitted by:   Kevin Zheng <kevinz5000@gmail.com>
    PR:             254654
    MFH:            2021Q2

 shells/fish/pkg-plist | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)