Bug 254749 - www/squid3: Add DEPRECATED and EXPIRATION_DATE
Summary: www/squid3: Add DEPRECATED and EXPIRATION_DATE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Danilo G. Baio
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2021-04-03 20:55 UTC by Daniel Engberg
Modified: 2021-05-23 23:06 UTC (History)
2 users (show)

See Also:
dbaio: maintainer-feedback+
dbaio: merge-quarterly+

Attachments
Patch for squid3 (118.25 KB, patch)
2021-04-03 20:55 UTC, Daniel Engberg 		no flags Details | Diff
Patch for squid3 v2 (409 bytes, patch)
2021-05-20 22:24 UTC, Daniel Engberg 		diizzy: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-04-03 20:55:09 UTC 
Created attachment 223793 [details]
Patch for squid3

Remove squid3 from tree as it's no longer supported by upstream and doesn't build with OpenSSL 1.1

"Provided for archival purposes only. Not intended for general use in new installations."

Reference:
http://www.squid-cache.org/Versions/
Comment 1 Pavel Timofeev 2021-05-18 03:13:37 UTC 
I'd like to delete it only when freebsd 11 is OEL
Comment 2 Pavel Timofeev 2021-05-18 03:13:51 UTC 
EOL I meant
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-05-18 05:13:48 UTC 
@Reporter, if there are any changes required to support squid3 until 11.* EoL or correct problems with the port as is, such as BROKEN messages, using only base ssl, or other change, please re-open with additional details and change proposals
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2021-05-18 15:17:46 UTC 
We should at least add a deprecated entry?
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2021-05-19 01:52:45 UTC 
^Triage: Re-open pending patch to add deprecation notice and expiration date
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2021-05-20 22:24:21 UTC 
Created attachment 225139 [details]
Patch for squid3 v2

Add DEPRECATED and EXPIRATION_DATE
Comment 7 Pavel Timofeev 2021-05-21 14:56:24 UTC 
Comment on attachment 225139 [details]
Patch for squid3 v2

Well, as far as I understand I was supposed to set maintainer-approval to +.
Anyway, I'm ok with the patch
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-05-23 23:01:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=98d128a55b0761e7b2a53a861c1eb93e83ddfa45

commit 98d128a55b0761e7b2a53a861c1eb93e83ddfa45
Author:     Daniel Engberg <daniel.engberg.lists@pyret.net>
AuthorDate: 2021-05-23 21:25:52 +0000
Commit:     Danilo G. Baio <dbaio@FreeBSD.org>
CommitDate: 2021-05-23 22:58:47 +0000

    www/squid3: Mark as deprecated and set an expiry date

    Expiration date following expected EoL of FreeBSD 11.

    PR:             254749
    Approved by:    timp87@gmail.com (maintainer)

 www/squid3/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-05-23 23:04:55 UTC 
A commit in branch 2021Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7886a9905189798f2b702a932a4c462d7d0d5adc

commit 7886a9905189798f2b702a932a4c462d7d0d5adc
Author:     Daniel Engberg <daniel.engberg.lists@pyret.net>
AuthorDate: 2021-05-23 21:25:52 +0000
Commit:     Danilo G. Baio <dbaio@FreeBSD.org>
CommitDate: 2021-05-23 23:03:30 +0000

    www/squid3: Mark as deprecated and set an expiry date

    Expiration date following expected EoL of FreeBSD 11.

    PR:             254749
    Approved by:    timp87@gmail.com (maintainer)

    (cherry picked from commit 98d128a55b0761e7b2a53a861c1eb93e83ddfa45)

 www/squid3/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 10 Danilo G. Baio freebsd_committer freebsd_triage 2021-05-23 23:06:20 UTC 
Committed, thanks!