Bug 255111 - devel/ode: Update 0.13 -> 0.16.2
Summary: devel/ode: Update 0.13 -> 0.16.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
: 230359 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-04-16 09:28 UTC by Yuri Victorovich
Modified: 2022-11-04 05:38 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (acm)

Attachments
patch (4.45 KB, patch)
2021-04-16 09:28 UTC, Yuri Victorovich 		no flags Details | Diff
patch (635 bytes, patch)
2021-04-16 09:32 UTC, Yuri Victorovich 		no flags Details | Diff
patch (5.07 KB, patch)
2021-04-16 09:41 UTC, Yuri Victorovich 		acm: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2021-04-16 09:28:11 UTC 
Created attachment 224151 [details]
patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-04-16 09:32:56 UTC 
Created attachment 224152 [details]
patch
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2021-04-16 09:41:57 UTC 
Created attachment 224153 [details]
patch
Comment 3 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2021-04-16 17:24:42 UTC 
Hi Yuri, thanks for your patch file. Maybe the best should be test this new version of ode with ports maintained by amdmi3, you and I
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2021-04-16 17:50:19 UTC 
(In reply to Jose Alonso Cardenas Marquez from comment #3)

Sure.

Rebuilding all dependencies now:
games/stormbaancoureur
games/crashtest
games/gillo
games/xonotic
games/xmoto
games/alienarena
misc/ompl
misc/dartsim
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2021-04-16 19:58:03 UTC 
All of them build fine with the patch.
Comment 6 Tassilo Philipp 2021-09-26 14:12:14 UTC 
Thanks for working on this upgrade.

Just a note, as I was working on an upgrade myself before I saw this PR, here: the config knobs say that double precision support is broken with gimpact, as well as thread local storage support being experimental. I believe both claims aren't true anymore:

- I did a quick try using gimpact with double and it seems to work (by no means a thorough test, though); also, the ODE changelog mentions that this has been addressed on 01/12/08

- I'm not so sure about the TLS support, but cannot find any source or ./configure or anything mention it being experimental (checked versions >= 0.14)


So yeah, it's just a detail, but maybe the config knob descriptions could be cleaned up while at it.

Thanks!
Comment 7 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2022-11-03 18:30:24 UTC 
Comment on attachment 224153 [details]
patch

Yuri don't forget move WWW to Makefile
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2022-11-04 05:38:17 UTC 
Committed, thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-11-04 05:38:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5a627bd66810124dbcf9eefd036bff5a522af89

commit a5a627bd66810124dbcf9eefd036bff5a522af89
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-11-04 05:34:40 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-11-04 05:34:40 +0000

    devel/ode: Update 0.13 -> 0.16.2

    PR:             255111
    Approved by:    acm@ (maintainer)

 devel/ode/Makefile                                 | 58 ++++++++++------------
 devel/ode/distinfo                                 |  5 +-
 devel/ode/files/patch-CMakeLists.txt (new)         | 13 +++++
 devel/ode/files/patch-config.h.cmake.in (new)      | 11 ++++
 .../files/patch-ode_demo_demo__jointPR.cpp (gone)  | 11 ----
 .../files/patch-ode_demo_demo__jointPU.cpp (gone)  | 11 ----
 .../files/patch-ode_demo_demo__piston.cpp (gone)   | 11 ----
 devel/ode/pkg-plist                                | 12 +++--
 games/alienarena/Makefile                          |  2 +-
 games/crashtest/Makefile                           |  2 +-
 games/gillo/Makefile                               |  2 +-
 games/irrlamb/Makefile                             |  1 +
 games/stormbaancoureur/Makefile                    |  2 +-
 games/xmoto/Makefile                               |  2 +-
 games/xonotic/Makefile                             |  2 +-
 misc/dartsim/Makefile                              |  2 +-
 misc/ompl/Makefile                                 |  2 +-
 17 files changed, 69 insertions(+), 80 deletions(-)
Comment 10 Yuri Victorovich freebsd_committer freebsd_triage 2022-11-04 05:38:42 UTC 
*** Bug 230359 has been marked as a duplicate of this bug. ***