Hello, java/openjdk8 fails to build for armv7 for stable/13 context: poudriere with QEMU armv7 jail built with -x -a arm.armv7 on amd64 [...] [00:31:26] In file included from /usr/include/sys/user.h:40: [00:31:26] In file included from /usr/include/machine/pcb.h:43: [00:31:26] /usr/include/machine/frame.h:128:8: error: redefinition of 'frame' [00:31:26] struct frame { [00:31:26] ^ [00:31:26] /wrkdirs/usr/ports/java/openjdk8/work/openjdk-jdk8u-jdk8u282-b08.1/hotspot/src/share/vm/runtime/frame.hpp:65:7: note: previous definition is here [00:31:26] class frame VALUE_OBJ_CLASS_SPEC { [00:31:26] ^ [00:31:26] 1 warning and 1 error generated. [00:31:26] 1 warning generated.
Created attachment 224453 [details] v0 Can you try the attached patch?
(In reply to Mikael Urankar from comment #1) Hello, this fixes the build for me, many thanks
shall i close this PR?
(In reply to tech-lists from comment #3) Not until the fix is committed in the ports tree. We will take care of that.
Comment on attachment 224453 [details] v0 Build fixes are: Approved by: portmgr (build fix) MFH: 2021Q1
Are other java/openjdk* versions affected in the same way? Patches/fixes should be consistently applied across all relevent versions where ever possible
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1025536a1c76b990b4d38df2b27b8fc96cea76c6 commit 1025536a1c76b990b4d38df2b27b8fc96cea76c6 Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2021-05-14 08:30:52 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2021-05-14 08:30:52 +0000 java/openjdk8: Fix build on armv6/7 PR: 255326 Reported by: tech-lists@zyxst.net Approved by: portmgr (tier-2 / build fix blanket) ...rc_os__cpu_bsd__zero_vm_os__bsd__zero.cpp (new) | 24 ++++++++++++++++++++++ ...h-hotspot_src_os_bsd_vm_os__perf__bsd.cpp (new) | 18 ++++++++++++++++ 2 files changed, 42 insertions(+)