Bug 255409 - net/gsocket needs RUN_DEPENDS= bash:shells/bash
Summary: net/gsocket needs RUN_DEPENDS= bash:shells/bash
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-26 08:10 UTC by Stefan Grundmann
Modified: 2021-05-22 22:45 UTC (History)
4 users (show)

See Also:
lwhsu: maintainer-feedback? (arr)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Grundmann 2021-04-26 08:10:18 UTC 
since all the scripts installed by net/gsocket are bash scripts, the port must set bash:shells/bash as RUN_DEPENDS.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2021-04-26 08:53:18 UTC 
(In reply to Stefan Grundmann from comment #0)
Are those scripts compatible with /bin/sh? If so, we can replace the shebang line.
Comment 2 Stefan Grundmann 2021-04-26 11:33:12 UTC 
(In reply to Li-Wen Hsu from comment #1)
These scripts are not compatible with /bin/sh.
Comment 3 Andrew Reiter 2021-04-28 21:26:23 UTC 
I am ok with adding this dependency. Thank you for reporting it. How do you feel @lwhsu? (lwhsu@freebsd.org)
Comment 4 Li-Wen Hsu freebsd_committer freebsd_triage 2021-04-30 01:13:57 UTC 
(In reply to Andrew Reiter from comment #3)
Yes this seems the right way to go. Can you create a patch for it?  It would be nice to be created by git format-patch.
Comment 5 Andrew Reiter 2021-04-30 01:16:49 UTC 
(In reply to Li-Wen Hsu from comment #4)
Definitely will do.. sg2342@googlemail.com if you have one already, just post it so it can be tested. Otherwise, I will make one in the next day or so. Thank you for pointing this out!
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-05-19 08:58:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bcf86b3dc26e59be6fa313ed2ce91a0423b311b6

commit bcf86b3dc26e59be6fa313ed2ce91a0423b311b6
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-05-19 08:56:12 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-05-19 08:56:25 +0000

    net/gsocket: add missing run-time dependency on GNU Bash

    This port installs a number of shell scripts riddled with bashisms,
    most notably, double bracket expressions, so fixing them to become
    POSIX shell-compliant does not look feasible or, rather, practical.

    While here, shorten the COMMENT without sacrificing its meaning so
    ``pkg search gsocket'' or ``pkg info | grep gsocket'' would fit in
    standard 80-character terminal and fix one minor whitespace nit.

    PR:     255409

 net/gsocket/Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 7 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-05-19 09:00:04 UTC 
Committed with minor collateral improvements, thank you!
Comment 8 Andrew Reiter 2021-05-22 22:45:37 UTC 
(In reply to Alexey Dokuchaev from comment #7)
Thank you for doing this... had a busy few weeks and this slipped through for me :-/.