Bug 255446 - graphics/opencv: uses WITH_GDAL but does not depend on it
Summary: graphics/opencv: uses WITH_GDAL but does not depend on it
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-27 19:23 UTC by Martin Birgmeier
Modified: 2021-07-24 17:58 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2021-04-27 19:23:02 UTC 
Scenario:
- latest ports
- graphics/opencv has in its Makefile CMAKE_ON = ... WITH_GDAL ... but does not include a dependency on gdal

Result:
- after installing from a self-built package:

[0]# pkg check -da  
Checking all packages: 100%
opencv is missing a required shared library: libgdal.so.3
pkg check -da  11.69s user 0.02s system 99% cpu 11.825 total
[0]# 

Expected result:
- Either the WITH_GDAL is changed to its opposite, or the dependency is added.

-- Martin
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-07-18 13:54:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c582239e8a2b795fc0a7f51a3463cee9998cfab8

commit c582239e8a2b795fc0a7f51a3463cee9998cfab8
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2021-07-18 12:13:52 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-07-18 13:52:58 +0000

    graphics/opencv: add makefile options

    Bring back lot of the options that were available in the old port.

    Reported by:    Ivan Rozhuk <rozhuk.im@gmail.com>
    Original by:    alt2600@icloud.com
                    VVD <vvd@unislabs.com>
    PR:             253110
    PR:             255446

 graphics/opencv/Makefile                           | 194 ++++++++++++++++-----
 .../patch-cmake_OpenCVFindLibsGrfmt.cmake (new)    |  14 ++
 ...atch-modules_imgcodecs_src_grfmt__png.cpp (new) |  11 ++
 graphics/opencv/pkg-plist                          | 139 ++++++++-------
 4 files changed, 248 insertions(+), 110 deletions(-)
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2021-07-18 13:57:27 UTC 
Moin moin 

The GDAL has been added.

mfg Tobias
Comment 3 Martin Birgmeier 2021-07-24 17:58:37 UTC 
Thank you Tobias.

-- Martin