Bug 255498 - textproc/py-csvkit: missing dependency: py-pyicu
Summary: textproc/py-csvkit: missing dependency: py-pyicu
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-29 19:20 UTC by Alexis Praga
Modified: 2021-05-01 13:26 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (matthew)

Attachments
Add missing dependency (670 bytes, patch)
2021-04-29 19:20 UTC, Alexis Praga 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Praga 2021-04-29 19:20:00 UTC 
Created attachment 224549 [details]
Add missing dependency

csvgrep complains that :
"pkg_resources.DistributionNotFound: The 'PyICU>=2.4.2' distribution was not found and is required by agate"

Installing py37-pyicu fixes the problem.
Comment 1 Matthew Seaman freebsd_committer freebsd_triage 2021-05-01 10:53:26 UTC 
Thank you very much for the report.  This is however not quite correct.  The csvkit module does not in itself depend on PyICU.  That's an inherited dependency from the agate module, which certainly should depend on PyICU but unaccountably doesn't, a deficiency I shall now fix.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-05-01 13:13:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=65de32a02047e5a4a6408e6f99d747c8b6be9979

commit 65de32a02047e5a4a6408e6f99d747c8b6be9979
Author:     Matthew Seaman <matthew@FreeBSD.org>
AuthorDate: 2021-05-01 10:57:44 +0000
Commit:     Matthew Seaman <matthew@FreeBSD.org>
CommitDate: 2021-05-01 13:13:27 +0000

    devel/py-agate: Add missing devel/py-pyicu dependency

    Alexis initially reported this as a missing dependency on py-csvkit,
    but it's actually py-agate that has the deficiency.

    PR:             255498
    Reported by:    Alexis Praga

 textproc/py-agate/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 3 Matthew Seaman freebsd_committer freebsd_triage 2021-05-01 13:14:39 UTC 
Committed, thanks!
Comment 4 Alexis Praga 2021-05-01 13:26:21 UTC 
Thanks for correcting it so quickly :)