Created attachment 224782 [details] Patch to version 1.23 Upgrade sysutils/xosview to version 1.23
Thanks for the patch! Please do not use '# $FreeBSD$' in the Makefile anymore. This is obsolote since the ports tree was converted from subversion to git ;) And what is the intent of $FreeBSD$ in the COMMENT line?
portlint suggest to me to add $FreeBSD$ in the COMMENT line root@ximbiribaifpb:/usr/ports/sysutils/xosview # portlint FATAL: Makefile: [2]: header should be followed by $FreeBSD$. FATAL: Makefile: no $FreeBSD$ line in comment section. 2 fatal errors and 0 warnings found. root@ximbiribaifpb:/usr/ports/sysutils/xosview #
(In reply to otacilio.neto from comment #2) > portlint suggest to me to add $FreeBSD$ in the COMMENT line > > root@ximbiribaifpb:/usr/ports/sysutils/xosview # portlint > FATAL: Makefile: [2]: header should be followed by $FreeBSD$. > FATAL: Makefile: no $FreeBSD$ line in comment section. > 2 fatal errors and 0 warnings found. Here it looks like this: #cd /usr/ports/sysutils/xosview #portlint -AC looks fine. So it seems your ports tree is not up to date? Did you switch vom svn to git? And another question: Is the old and the new maintainers address the same person?
(In reply to Rainer Hurling from comment #3) I have installed portlint from packages. Maybe the difference comes from it root@ximbiribaifpb:/usr/ports/sysutils/xosview # pkg upgrade -f portlint Updating FreeBSD repository catalogue... FreeBSD repository is up to date. All repositories are up to date. Checking integrity... done (0 conflicting) The following 1 package(s) will be affected (of 0 checked): Installed packages to be REINSTALLED: portlint-2.19.4 Number of packages to be reinstalled: 1 Proceed with this action? [y/N]: y [1/1] Reinstalling portlint-2.19.4... [1/1] Extracting portlint-2.19.4: 100% root@ximbiribaifpb:/usr/ports/sysutils/xosview # portlint -AC FATAL: Makefile: [2]: header should be followed by $FreeBSD$. FATAL: Makefile: no $FreeBSD$ line in comment section. 2 fatal errors and 0 warnings found. root@ximbiribaifpb:/usr/ports/sysutils/xosview # "And another question: Is the old and the new maintainers address the same person?" Yes, it's me. I'm switching the e-mail address because I read gmail.com most frequently than bsd.com.br
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e060db41935278828ec825f88d46b1be1244008d commit e060db41935278828ec825f88d46b1be1244008d Author: OtacÃlio de Araújo Ramos Neto <otaciliodearaujo@gmail.com> AuthorDate: 2021-05-09 09:45:02 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2021-05-09 12:13:02 +0000 sysutils/xosview: Update to 1.23 - Change maintainers address - Patch under files is upstream now [1] [1] https://github.com/hills/xosview/commit/cd7dd1954760fdadbe63bd1184f41ae7e7af62bc#diff-32f3a92badc7976806ca65890b152452bca7c434e41dd60946474ad55b6fee62 PR: 255718 Co-authored-by: Rainer Hurling <rhurlin@FreeBSD.org> sysutils/xosview/Makefile | 6 +++-- sysutils/xosview/distinfo | 6 ++--- sysutils/xosview/files/patch-bsd_kernel.cc (gone) | 32 ----------------------- sysutils/xosview/pkg-descr | 2 +- 4 files changed, 8 insertions(+), 38 deletions(-)
The switch from svn to git was in the first days of april. My portlint is v2.19.5 atm ;) Committed, thanks!