Bug 255986 - devel/rubygem-oci: update to 2.14.0
Summary: devel/rubygem-oci: update to 2.14.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/oracle/oci-ruby-sd...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-19 04:47 UTC by Alessandro Sagratini
Modified: 2021-05-26 10:26 UTC (History)
2 users (show)

See Also:

Attachments
trivial update of Makefile and distinfo (943 bytes, patch)
2021-05-19 04:47 UTC, Alessandro Sagratini 		ale_sagra: maintainer-approval+
Details | Diff
trivial update of distinfo and port version (943 bytes, patch)
2021-05-26 09:08 UTC, Alessandro Sagratini 		ale_sagra: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Sagratini 2021-05-19 04:47:41 UTC 
Created attachment 225078 [details]
trivial update of Makefile and distinfo

trivial update of Makefile and distinfo
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2021-05-26 06:34:13 UTC 
Hello!

Could you please use DISTVERSION instead of PORTVERSION:
---
Example 2. Using DISTVERSION

When the version only contains numbers separated by dots, dashes or underscores, use DISTVERSION.

PORTNAME=   nekoto
DISTVERSION=	1.2-4

It will generate a PORTVERSION of 1.2.4.
---
https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-naming
Comment 2 Alessandro Sagratini 2021-05-26 09:08:02 UTC 
Created attachment 225269 [details]
trivial update of distinfo and port version

updating new patch that also switches from PORTVERSION to DISTVERSION
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-05-26 10:25:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a77739039a0e09b3cb09e211d8f53b44fa18f59

commit 5a77739039a0e09b3cb09e211d8f53b44fa18f59
Author:     Alessandro Sagratini <ale_sagra@hotmail.com>
AuthorDate: 2021-05-26 10:19:42 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2021-05-26 10:24:30 +0000

    devel/rubygem-oci: update to 2.14.0

    - Use DISTVERSION instead of PORTVERSION

    ChangeLog: https://github.com/oracle/oci-ruby-sdk/releases/tag/v2.14.0

    PR:             255986
    Approved by:    dbaio, garga (mentors, implicit)

 devel/rubygem-oci/Makefile | 2 +-
 devel/rubygem-oci/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2021-05-26 10:26:45 UTC 
Commited thanks!