Created attachment 225150 [details] dhcp_probe-1.3.1 git diff The attached git diff patch updates the net-mgmt/dhcp_probe port to version 1.3.1. I am the maintainer of this port. The following git commands need to be run as well: git mv files/patch-extras-dhcp__probe.cf.sample files/patch-extras_dhcp__probe.cf.sample git rm files/patch-src_daemonize.c
A few points: * Your "The following git commands need to be run as well" can be included in the git patch itself, by: - Making a git branch - Doing the git add/rm commands - Committing the patch locally - Doing "git format-patch main" to get a patchfile * It's a good idea to set maintainer-feedback to "+" if you approve of it, so we can commit it
^Triage: Thanks for taking this Neel. Minor recommendation correction: Use the maintainer-approval 'attachment' flag (set to +), to signify maintainer approval on patches for ports you maintain [1] [1] https://wiki.freebsd.org/Bugzilla/DosAndDonts#Maintainers
Comment on attachment 225150 [details] dhcp_probe-1.3.1 git diff Thank you Neel and Kubilay for informing me about the correct procedures. I'm new to updating ports so I blindly followed the Porter's Handbook on this. [1] If I need to submit an updated patch with the added git commands, please let me know. [1] https://docs.freebsd.org/en/books/porters-handbook/upgrading/
Committed!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2c9daf663dd7190d1495c2b6120e9dd2bbb8244b commit 2c9daf663dd7190d1495c2b6120e9dd2bbb8244b Author: Kevin Hung <khung@nullaxiom.com> AuthorDate: 2021-05-22 17:40:42 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2021-05-22 17:41:20 +0000 net-mgmt/dhcp_probe: Update to 1.3.1 PR: 256053 net-mgmt/dhcp_probe/Makefile | 8 +- net-mgmt/dhcp_probe/distinfo | 5 +- ...f.sample => patch-extras_dhcp__probe.cf.sample} | 8 +- net-mgmt/dhcp_probe/files/patch-src_bootp.c | 27 +---- net-mgmt/dhcp_probe/files/patch-src_configfile.c | 23 ++-- net-mgmt/dhcp_probe/files/patch-src_configfile.h | 6 +- .../dhcp_probe/files/patch-src_daemonize.c (gone) | 10 -- net-mgmt/dhcp_probe/files/patch-src_defs.h | 20 +++- net-mgmt/dhcp_probe/files/patch-src_dhcp__probe.c | 124 +++++++-------------- net-mgmt/dhcp_probe/files/patch-src_dhcp__probe.h | 6 +- net-mgmt/dhcp_probe/files/patch-src_get__myeaddr.c | 10 +- net-mgmt/dhcp_probe/files/patch-src_get__myeaddr.h | 4 +- 12 files changed, 99 insertions(+), 152 deletions(-)